From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 505A0138334 for ; Mon, 6 Aug 2018 20:09:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8FDF5E0857; Mon, 6 Aug 2018 20:09:10 +0000 (UTC) Received: from mail-ua0-x244.google.com (mail-ua0-x244.google.com [IPv6:2607:f8b0:400c:c08::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 33F06E0769 for ; Mon, 6 Aug 2018 20:09:09 +0000 (UTC) Received: by mail-ua0-x244.google.com with SMTP id g18-v6so13607410uam.6 for ; Mon, 06 Aug 2018 13:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scriptkitty-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=2UMFOV6hkV6RiwWogP5MJXWQrrKcSfZTpKvaPHX06BE=; b=rmPYA7J+7Eu2imRTLdEePgHJvX3zDhKiR/W9HPgKqj6/hCYV9zDzKvc7xoMnS+VPMD ZXfjcN1rE9qmnZlW0OiGesnx0UqBWkc7caU08wNZp6zTiOzM7P7MZz9UyOzd0bnMBJH+ GC8JOFjqi22ujU/JlofhOVFCd4v/VIH2II46c9M1CGIxND+gk1EXJuGhBPX6VmpqkULJ mkvBR+NqvvvJYWiD/iC+H/u9j9Q8Th+1SzFbFOlkvT9O4m8f3+DG0wx9whdGciyXdsxn qaNLw9gu02hvZtEg8Mi2fpxFBZHgYHr7kPbDPMZ6Dmy/M/w+VmZa81Se0CkGyJ6pPtQB QUzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=2UMFOV6hkV6RiwWogP5MJXWQrrKcSfZTpKvaPHX06BE=; b=JJQr55IGSTYQNng0R/3g2Ed4Us7iyl9LsTi+8iEqESV2603sz1VZ4dFjHVo6MQj3R1 nPlGmXcwsZhqCILgTipfiy4FP86Hlb/5O7InXlh9McaG9VurV6Vk4qS9iBKDU8B4dxaV w6aZ7J43p9tMbm2k48VAtPqOezMaSeWBsbOpgT13ff87nAiSqbGZjHYByIS+H69TkkNE bYf1n7adlQ5JhwHzp4v/Aex799I5Atan/XmKfQMJU7OYgGfvSdd9c0X2t2zYhEvVk1/z QWUyTzN4F2LIn5j9WJPiscJ8cp9K/Cyf9A9mqGmmLowp4lwfZUoccDUYSBDlwI/XQWjM 0EGw== X-Gm-Message-State: AOUpUlFT1vnAz7Ci5ETOX3T6Zg5NAKTkb6aWlsgRHhtywJFzWf86k8eV wTuP272KDuu3zaLF+mxx1x4CrQTBHaw1U3Lri7hbCuSR X-Google-Smtp-Source: AAOMgpdEdtnRBaLpDiziAIb9LA5ipb63bgmnHgETxUl3Vy75miUexBa9KzjgyWCydWbCcni2/Gts6q8NjUwPgUiAwD4= X-Received: by 2002:ab0:13c7:: with SMTP id n7-v6mr11529166uae.47.1533586148727; Mon, 06 Aug 2018 13:09:08 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Sender: antarus@scriptkitty.com Received: by 2002:ab0:73d6:0:0:0:0:0 with HTTP; Mon, 6 Aug 2018 13:09:08 -0700 (PDT) X-Originating-IP: [2620:0:1003:510:28c6:e8a9:1267:5710] In-Reply-To: References: <20180806180946.6575-1-floppym@gentoo.org> <23400.40429.732934.345187@a1i15.kph.uni-mainz.de> <3181714.0gOeftyz4v@tp> From: Alec Warner Date: Mon, 6 Aug 2018 16:09:08 -0400 X-Google-Sender-Auth: LuELtyvVQ0tMpuQNyiUDLvEIyho Message-ID: Subject: Re: [gentoo-dev] [PATCH] systemd.eclass: set BDEPEND for EAPI 7 To: Gentoo Dev Content-Type: multipart/alternative; boundary="000000000000a0b6d50572c9d9bf" X-Archives-Salt: b3481dd8-934e-4f7b-901e-cf67e116069c X-Archives-Hash: 6e7838eca5e589ba2292ef9f604af7bf --000000000000a0b6d50572c9d9bf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Aug 6, 2018 at 3:51 PM, Mike Gilbert wrote: > On Mon, Aug 6, 2018 at 3:35 PM Vadim A. Misbakh-Soloviov > wrote: > > > > =D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D0=BF=D0=BE= =D0=BD=D0=B5=D0=B4=D0=B5=D0=BB=D1=8C=D0=BD=D0=B8=D0=BA, 6 =D0=B0=D0=B2=D0= =B3=D1=83=D1=81=D1=82=D0=B0 2018 =D0=B3. 22:13:49 MSK =D0=BF=D0=BE=D0=BB=D1= =8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C > Ulrich > > Mueller =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB: > > > >>>>> On Mon, 6 Aug 2018, Mike Gilbert wrote: > > > > -DEPEND=3D"virtual/pkgconfig" > > > > +if [[ ${EAPI} =3D=3D [0123456] ]]; then > > > > > > This should use ${EAPI:-0} because for EAPI 0 the variable can be > > > empty. > > > > > > > + DEPEND=3D"virtual/pkgconfig" > > > > +else > > > > + BDEPEND=3D"virtual/pkgconfig" > > > > +fi > > > > And how about "-le"/"-lt"/"-ge"/"-gt"/"-eq" syntax? > > Or even ((EAPI<7))? > > Are they forbidden to use in eclasses? > > If I recall correctly, EAPI values are not required to be numeric, and > are not required to increase in any predictable manner. They only do > so by convention. > They do not even do so by convention; there are numerous EAPIs in the wild that are non-numeric. -A > > > Anyway, I think, it is possible to add something like "EAPI=3D${EAPI:-0= }" > > somewhere at the top of eclass, to don't call "${EAPI:-0}" each time > when EAPI > > variable is needed. > > Re-assigning EAPI within an eclass seems like a bad idea to me. > > A better solution would be to ban ebuilds with no defined EAPI, but > that's outside the scope of this patch. > > --000000000000a0b6d50572c9d9bf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Mon, Aug 6, 2018 at 3:51 PM, Mike Gilbert <floppym@gentoo.org&= gt; wrote:
On Mon= , Aug 6, 2018 at 3:35 PM Vadim A. Misbakh-Soloviov
<gentoo@mva.name> wrote:
>
> =D0=92 =D0=BF=D0=B8=D1=81=D1=8C=D0=BC=D0=B5 =D0=BE=D1=82 =D0=BF=D0=BE= =D0=BD=D0=B5=D0=B4=D0=B5=D0=BB=D1=8C=D0=BD=D0=B8=D0=BA, 6 =D0=B0=D0=B2=D0= =B3=D1=83=D1=81=D1=82=D0=B0 2018 =D0=B3. 22:13:49 MSK =D0=BF=D0=BE=D0=BB=D1= =8C=D0=B7=D0=BE=D0=B2=D0=B0=D1=82=D0=B5=D0=BB=D1=8C Ulrich
> Mueller =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB:
> > >>>>> On Mon, 6 Aug 2018, Mike Gilbert wrote:
> > > -DEPEND=3D"virtual/pkgconfig"
> > > +if [[ ${EAPI} =3D=3D [0123456] ]]; then
> >
> > This should use ${EAPI:-0} because for EAPI 0 the variable can be=
> > empty.
> >
> > > +=C2=A0 =C2=A0DEPEND=3D"virtual/pkgconfig"
> > > +else
> > > +=C2=A0 =C2=A0BDEPEND=3D"virtual/pkgconfig"
> > > +fi
>
> And how about "-le"/"-lt"/"-ge"/"-g= t"/"-eq" syntax?
> Or even ((EAPI<7))?
> Are they forbidden to use in eclasses?

If I recall correctly, EAPI values are not required to be numeric, a= nd
are not required to increase in any predictable manner. They only do
so by convention.

They do not even do s= o by convention; there are numerous EAPIs in the wild that are non-numeric.=

-A
=C2=A0

> Anyway, I think, it is possible to add something like "EAPI=3D${E= API:-0}"
> somewhere at the top of eclass, to don't call "${EAPI:-0}&quo= t; each time when EAPI
> variable is needed.

Re-assigning EAPI within an eclass seems like a bad idea to me.

A better solution would be to ban ebuilds with no defined EAPI, but
that's outside the scope of this patch.


--000000000000a0b6d50572c9d9bf--