From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 0CDE413800E for ; Mon, 6 Aug 2012 19:46:46 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id DBF02E0798; Mon, 6 Aug 2012 19:46:29 +0000 (UTC) Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com [209.85.215.53]) by pigeon.gentoo.org (Postfix) with ESMTP id 20D4CE076C for ; Mon, 6 Aug 2012 19:45:47 +0000 (UTC) Received: by lahc1 with SMTP id c1so777705lah.40 for ; Mon, 06 Aug 2012 12:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=NM5npyMhI8CkWlwGuRajtI4X1mI/3fuRajVvw87lnqA=; b=S/xR9H/quDKbV5ZWTzO1Toc5Cxw1to3uLBiSECBGZfr+IzDF4GV7tN+HLhaX54fmto 7iqUnraPTEj2z4KvkZuo+zDne8i44yVP8gMtdqaqLG05wzqSoTUv6f3+R1smtiITiKAs BzjSUWdudg2ehLa1AX+zPnVOIQD3Z+ifT4Ol1XGD/Vp5ng+E5bnuI2RNZNgGJmULZZgM twv1qNh/J5MTwqLbGD/B9ZMpGUVNv1SjmCllQoM9Mf5FbGyNw9PEq768RfdqvZfcvY+z Ukf+Ql23Xe096up6OSlZilxOH99DnuNgdICNsbONi+OEzQqcWd7A64sufd15nRRzqgVo L0Hg== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.152.114.3 with SMTP id jc3mr11941915lab.11.1344282346862; Mon, 06 Aug 2012 12:45:46 -0700 (PDT) Received: by 10.114.0.167 with HTTP; Mon, 6 Aug 2012 12:45:46 -0700 (PDT) Date: Tue, 7 Aug 2012 07:45:46 +1200 Message-ID: Subject: [gentoo-dev] eutils.eclass / EPATCH_EXCLUDE defined wrong? From: Kent Fredric To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 X-Archives-Salt: 32b718bf-3332-40f3-ba89-d8cb087d3d43 X-Archives-Hash: 8bfcee1b4459ec80451e6fb8400aa419 I was goofing around trying to get current dev-vcs/git-9999 building by skipping the CVS patch ( which is applied with epatch ) and I had a bizzare amount of time working out how to get it working. Looking at the source of eutils.eclass ' # Let people filter things dynamically ' suggests to me that this field is for use by a end user via package.env and friends. However, every time I ran emerge, the 'environment' file simply suggests that EPATCH_EXCLUDE was ="" . Looking elsewhere in eutils.eclass, I spied a forced initialization of EPATCH_EXCLUDE, which implicitly means you can't actually use this to exclude patches outside .ebuild Commenting this line out, yielded the result I had been expecting, the CVS patch being skipped . I only thought I could do this because I used something like this once upon a time with net-im/psi-9999 and thought it was just "normal" to be able to disable patches if I really wanted to. ( But I see now they acheive this by copying MY_EPATCH_EXCLUDE to EPATCH_EXCLUDE in the .ebuild ). So, is this variable guarded against user tampering intentionally? It sure beats hacking the ebuild. ( Side note, what would also be nice is some sort of warning if things you set in package.env are getting totally ignored. But thats a hard problem ) -- Kent perl -e "print substr( \"edrgmaM SPA NOcomil.ic\\@tfrken\", \$_ * 3, 3 ) for ( 9,8,0,7,1,6,5,4,3,2 );" http://kent-fredric.fox.geek.nz