From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 4A63D13877A for ; Sun, 22 Jun 2014 13:11:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 25FEFE096C; Sun, 22 Jun 2014 13:11:30 +0000 (UTC) Received: from mail-qg0-f51.google.com (mail-qg0-f51.google.com [209.85.192.51]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id CDC93E0968 for ; Sun, 22 Jun 2014 13:11:28 +0000 (UTC) Received: by mail-qg0-f51.google.com with SMTP id z60so4980493qgd.24 for ; Sun, 22 Jun 2014 06:11:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=wMAs24Q9n5EJDwOEib98OqSYjBROm85/GSgeFUTJCIA=; b=DrPuAyIYhLrW34yMECulPhEXxlhhe4qyeSzzD+43YJXCOJ0YWv54X/KWjWvZd/K5zz TbdXyt43PlXc/AJEyEoYX++9YEM1gEBu6rqvLZpLen/DJ/9XCm7mPIz1o1sSKSgqqcFy uXt7WxLGdb+Kwt4lxNKjkSzqGO5FHrr2g6Wc/kDdKAzFq2j4lnqOSBzaYmb5de81Ocdq RL0gh3In4LzyMPstEZdM9dyDZNQtxZ1MB0FR5FI7V3WYvP9QQHir95i22bpUCb5vQb8f rNGBLL8O0xPjKmf0ZU7V43uGadXVQbUEd1QpUPQvthEBQCzrfz/6M/1UOzviiAZWEZ8B w8Wg== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.224.8.131 with SMTP id h3mr23889861qah.61.1403442687799; Sun, 22 Jun 2014 06:11:27 -0700 (PDT) Received: by 10.140.51.132 with HTTP; Sun, 22 Jun 2014 06:11:27 -0700 (PDT) In-Reply-To: References: <201406221141.08772.dilfridge@gentoo.org> Date: Mon, 23 Jun 2014 01:11:27 +1200 Message-ID: Subject: Re: [gentoo-dev] Re: perl-module.eclass: respect CFLAGS, LDFLAGS - please review From: Kent Fredric To: gentoo-dev@lists.gentoo.org Content-Type: multipart/alternative; boundary=001a11c2be64de79f204fc6c76a2 X-Archives-Salt: 9302f9a5-d130-48f5-9f18-6d2655ac9264 X-Archives-Hash: 47606b533e506f48b81ff9bff5ffc264 --001a11c2be64de79f204fc6c76a2 Content-Type: text/plain; charset=UTF-8 On 23 June 2014 01:02, Duncan <1i5t5.duncan@cox.net> wrote: > > The usual conditional for that is USE=custom-cflags or a similar variant > like custom-optimization. See the firefox ebuilds, which use both. > > $ equery -N u firefox | grep custom > - - custom-cflags : Build with user-specified CFLAGS (unsupported) > + + custom-optimization : Fine-tune custom compiler optimizations (-Os, > -O0, -O1, -O2, -O3) > > > Generally, such USE flags are discouraged in gentoo, where honoring a > user's CFLAGS, etc. and letting them keep the pieces if it comes to that > is the norm. Where upstream refuses to support custom cflags, however, > the USE flag solution seems to be an accepted at maintainer discretion. The problem with a USE flag here as such is the change this eclass makes affects >900 packages in dev-perl/ , and its not easy to casually determine which of those packages have any C bits where CFLAGS are even meaningful. Which would mean having >900 packages with a new IUSE value that did nothing for a majority of them. -- Kent --001a11c2be64de79f204fc6c76a2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

= On 23 June 2014 01:02, Duncan <1i5t5.duncan@cox.net> wrot= e:

The usual conditional for that is USE=3Dcustom-cflags or a similar va= riant
like custom-optimization. =C2=A0See the firefox ebuilds, which use both.
$ equery -N u firefox | grep custom
=C2=A0- - custom-cflags =C2=A0 =C2=A0 =C2=A0 =C2=A0: Build with user-specif= ied CFLAGS (unsupported)
=C2=A0+ + custom-optimization =C2=A0: Fine-tune custom compiler optimizatio= ns (-Os,
-O0, -O1, -O2, -O3)


Generally, such USE flags are discouraged in gentoo, where honoring a
user's CFLAGS, etc. and letting them keep the pieces if it comes to tha= t
is the norm. =C2=A0Where upstream refuses to support custom cflags, however= ,
the USE flag solution seems to be an accepted at maintainer discretion.


The problem with a = USE flag here as such is the change this eclass makes affects >900 packa= ges in dev-perl/ , and its not easy to casually determine which of those pa= ckages have any C bits where CFLAGS are even meaningful.

Which would mean having >900 packag= es with a new IUSE value that did nothing for a majority of them.
=


--
Kent
--001a11c2be64de79f204fc6c76a2--