public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Kent Fredric <kentfredric@gmail.com>
To: gentoo-dev <gentoo-dev@lists.gentoo.org>
Subject: Re: [gentoo-dev] On banning merge commits
Date: Mon, 9 May 2016 00:18:32 +1200	[thread overview]
Message-ID: <CAATnKFBHX_=rQXaeuq4OCxmN+Y5b70jd46G_njKLr7hgDxp7jw@mail.gmail.com> (raw)
In-Reply-To: <572F2C61.6070103@gentoo.org>

On 9 May 2016 at 00:09, Anthony G. Basile <blueness@gentoo.org> wrote:
> 1. announce to gentoo-dev@ the intention to start a branch intending to
> merge
>
> 2. hack hack hack
>
> 3. test the merge for any conflicts etc,
>
> 4. announce to the list a date/time to merge
>
> 5. if okay, ermge


I think that's a bit excessive myself. I dislike merges, but I don't
hate them *quite* that much to justify such formality.

Because IMO, its not about forbidding merges, its about making sure
the use of merges is appropriate and effective.

For instance, stabilizing ~100 ebuilds in response to a single stable
request, it would make logical sense to group all those stabilizations
so that they appear on the left side as a single atomic change, while
still existing as a series on the right side of the branch for
historical accuracy
and for other practical reasons ( like simplified commit reverts )

Pretty much *anything* that does "bulk changes for single purpose" is
a good candidate for a merge.

For instance, there's ~100 commits sitting around somewhere in a
repository for introducing Perl 5.24 to the tree, which requires a
commit for each and every entry in virtual/perl-*

It would make much sense for this series to be visible on Master as a
"add Perl 5.24 to tree" commit, because all the changes are inherently
interdependent,
and it would make little sense to rewind to a specific point within
that series and use it as a portage tree.

But that's not significant enough to warrant a lot of formal fluffing around.

It for sure would be best if that 100 commit range was rebased before
merging, but it should still be a non-fast-forward merge just to keep
the history logical.



-- 
Kent

KENTNL - https://metacpan.org/author/KENTNL


  reply	other threads:[~2016-05-08 12:18 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-07 23:52 [gentoo-dev] On banning merge commits Patrice Clement
2016-05-08  5:09 ` Michał Górny
2016-05-08  5:44   ` cbergstrom
2016-05-08  8:21     ` Greg KH
2016-05-08  9:35       ` Daniel Campbell
2016-05-08  8:58     ` [gentoo-dev] " Duncan
2016-05-08  9:25       ` Kent Fredric
2016-05-08 10:21         ` Duncan
2016-05-08 10:35         ` Dirkjan Ochtman
2016-05-08 10:30   ` [gentoo-dev] " Dirkjan Ochtman
2016-05-08 12:00     ` Michał Górny
2016-05-08 12:31       ` Dirkjan Ochtman
2016-05-08 11:13   ` Andreas K. Hüttel
2016-05-08 11:28     ` M. J. Everitt
2016-05-08  9:15 ` Andrew Savchenko
2016-05-08 10:06 ` Amadeusz Żołnowski
2016-05-08 12:53   ` Brian Dolbec
2016-05-08 15:15     ` Jeroen Roovers
2016-05-08 22:25     ` Daniel Campbell
2016-05-08 11:25 ` Andreas K. Hüttel
2016-05-08 11:57   ` Rich Freeman
2016-05-08 12:07     ` Kent Fredric
2016-05-08 21:56     ` [gentoo-dev] " Duncan
2016-05-08 12:09   ` [gentoo-dev] " Anthony G. Basile
2016-05-08 12:18     ` Kent Fredric [this message]
2016-05-08 12:34       ` Rich Freeman
2016-05-08 12:43         ` Anthony G. Basile
2016-05-08 22:02         ` [gentoo-dev] " Duncan
2016-05-08 17:03 ` [gentoo-dev] " Alexis Ballier
2016-05-08 17:07   ` Kent Fredric
2016-05-09 11:27     ` Kristian Fiskerstrand
2016-05-09 12:23       ` Rich Freeman
2016-05-09 12:36         ` Kent Fredric
2016-05-09 12:59           ` Rich Freeman
2016-05-10 12:04     ` Alexis Ballier
2016-05-10 14:18       ` Kent Fredric
2016-05-11 10:21         ` Alexis Ballier
2016-05-11 14:34           ` Kent Fredric
2016-05-11 15:12             ` Rich Freeman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAATnKFBHX_=rQXaeuq4OCxmN+Y5b70jd46G_njKLr7hgDxp7jw@mail.gmail.com' \
    --to=kentfredric@gmail.com \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox