[gentoo-dev] Proposal to fix distutils_install_for_testing to install proper egg-info

[gentoo-dev] Proposal to fix distutils_install_for_testing to install proper egg-info

[Mathy Vanvoorden]

[-- Attachment #1.1: Type: text/plain, Size: 710 bytes --]

Hi,

As requested in this PR I submit this patch to gentoo-dev for review /
approval.

https://github.com/gentoo/gentoo/pull/2746

The commit message:

Currently distutils_install_for_testing does not install the complete
egg-info into ${TEST_DIR}. This was first noticed by W. Trevor King and
reported in bug #524322. Based on info found in the related upstream
setuptools bug I added the necessary call to setuptools to create the
complete egg_info.

Without this certain packages (like cryptography) fail during testing
because they use introspection but the metadata isn't available.

Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=524322

--
Met vriendelijke groeten,
Best regards,

Mathy Vanvoorden

[-- Attachment #1.2: Type: text/html, Size: 1139 bytes --]

[-- Attachment #2: 0001-distutils-r1-make-distutils_install_for_testing-instal.txt --]
[-- Type: text/plain, Size: 1208 bytes --]

From 5a073983287a8fa097c5fbc60826e49aef45004b Mon Sep 17 00:00:00 2001
From: Mathy Vanvoorden <mathy@vanvoorden.be>
Date: Sat, 5 Nov 2016 00:01:51 +0100
Subject: [PATCH] distutils-r1 : make distutils_install_for_testing install
 proper egg-info

Currently distutils_install_for_testing does not install the complete
egg-info into ${TEST_DIR}. This was first noticed by W. Trevor King and
reported in bug #524322. Based on info found in the related upstream
setuptools bug I added the necessary call to setuptools to create the
complete egg_info.

Without this certain packages (like cryptography) fail during testing
because they use introspection but the metadata isn't available.

Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=524322
---
 eclass/distutils-r1.eclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index fb0362c..2db3be8 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -288,6 +288,8 @@ distutils_install_for_testing() {
 	PYTHONPATH=${libdir}:${PYTHONPATH}
 
 	local add_args=(
+		egg_info
+			--egg-base="${libdir}"
 		install
 			--home="${TEST_DIR}"
 			--install-lib="${libdir}"
-- 
2.7.3

[gentoo-dev] Re: Proposal to fix distutils_install_for_testing to install proper egg-info

[Mathy Vanvoorden]

[-- Attachment #1: Type: text/plain, Size: 972 bytes --]

This was merged to master by mgorny in commit
733fbcdcf08b74153bb6c3786e8f79ba031cb339

--
Met vriendelijke groeten,
Best regards,

Mathy Vanvoorden

2016-11-09 10:13 GMT+01:00 Mathy Vanvoorden <mathy@vanvoorden.be>:

> Hi,
>
> As requested in this PR I submit this patch to gentoo-dev for review /
> approval.
>
> https://github.com/gentoo/gentoo/pull/2746
>
> The commit message:
>
> Currently distutils_install_for_testing does not install the complete
> egg-info into ${TEST_DIR}. This was first noticed by W. Trevor King and
> reported in bug #524322. Based on info found in the related upstream
> setuptools bug I added the necessary call to setuptools to create the
> complete egg_info.
>
> Without this certain packages (like cryptography) fail during testing
> because they use introspection but the metadata isn't available.
>
> Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=524322
>
> --
> Met vriendelijke groeten,
> Best regards,
>
> Mathy Vanvoorden
>

[-- Attachment #2: Type: text/html, Size: 1927 bytes --]