From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RE4wi-0002nz-38 for garchives@archives.gentoo.org; Wed, 12 Oct 2011 19:58:32 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 38EB921C1C3; Wed, 12 Oct 2011 19:58:23 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 0180B21C187 for ; Wed, 12 Oct 2011 19:57:49 +0000 (UTC) Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: scarabeus) by smtp.gentoo.org (Postfix) with ESMTPSA id 48E8B1B4009 for ; Wed, 12 Oct 2011 19:57:49 +0000 (UTC) Received: by bkbzt12 with SMTP id zt12so616757bkb.40 for ; Wed, 12 Oct 2011 12:57:46 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.204.153.1 with SMTP id i1mr408376bkw.8.1318449466083; Wed, 12 Oct 2011 12:57:46 -0700 (PDT) Received: by 10.204.65.82 with HTTP; Wed, 12 Oct 2011 12:57:45 -0700 (PDT) In-Reply-To: <201110121551.06245.vapier@gentoo.org> References: <20111011164918.2103A2004B@flycatcher.gentoo.org> <201110121533.07266.vapier@gentoo.org> <201110121551.06245.vapier@gentoo.org> Date: Wed, 12 Oct 2011 21:57:45 +0200 Message-ID: Subject: Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in app-admin/chrpath: ChangeLog chrpath-0.13-r2.ebuild From: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= To: gentoo-dev@lists.gentoo.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: cc1b9710c4a816bb3b3ee1e868b03647 2011/10/12 Mike Frysinger : > On Wednesday 12 October 2011 15:44:53 Alec Warner wrote: >> If I want to add a patch to the list I might forget to to add the \ > > admittedly, i hit this every once in a while, and with all the "|| die" b= eing > implicit, it doesn't get caught right away. =C2=A0fortunately latest port= age will > issue a QA warning at the end along the lines of "command not found: > ${FILESDIR}/${P}-my-new.patch". =C2=A0so one can hope the maintainer test= s their > ebuilds and reviews QA output before committing ;). > -mike > That is the reason for the patch array implemented in the base eclass and why i want it in eapi5. PATCHES=3D( "patch1" # mycomment "patch2" # another bug number ) Example from wild: PATCHES=3D( "${FILESDIR}/${PN}-includes-libs-perl.patch" "${FILESDIR}/${PN}-fix_wrong_linker_opts.patch" "${FILESDIR}/${PN}-1.0.2-no_harfbuzz_tests.patxh" ) See the typo on last patch. >>> Preparing source in /var/tmp/portage/media-gfx/graphite2-1.0.3/work/gra= phite2-1.0.3 ... * Applying graphite2-includes-libs-perl.patch ... [ ok ] * Applying graphite2-fix_wrong_linker_opts.patch ... [ ok ] * QA: File or directory "/home/scarabeus/gentoo/gentoo-x86/media-gfx/graphite2/files/graphite2-1.0.= 2-no_harfbuzz_tests.patxh" does not exist. * QA: Check your PATCHES array or add missing file/directory. * ERROR: media-gfx/graphite2-1.0.3 failed (prepare phase): * Some patches failed. See above messages. Which is why i really avoid calling epatch myself, the only reason is to have conditional patches, which are root of all evil, because they can be broken with update and you won't notice anyway. Cheers Tom