From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-54169-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	by finch.gentoo.org (Postfix) with ESMTP id F262F138010
	for <garchives@archives.gentoo.org>; Sat, 25 Aug 2012 17:27:30 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 2E00FE064F;
	Sat, 25 Aug 2012 17:27:01 +0000 (UTC)
Received: from mail-pb0-f53.google.com (mail-pb0-f53.google.com [209.85.160.53])
	by pigeon.gentoo.org (Postfix) with ESMTP id E12C6E05E8
	for <gentoo-dev@lists.gentoo.org>; Sat, 25 Aug 2012 17:25:12 +0000 (UTC)
Received: by pbbro2 with SMTP id ro2so5827258pbb.40
        for <gentoo-dev@lists.gentoo.org>; Sat, 25 Aug 2012 10:25:12 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        bh=oy3zuqxcFZ6gvQgbE7F6PS7ueR7XbQ0aDtZOQL3tU0c=;
        b=qP8RDiggBwKjxFgjuktUXrSm8qzDm5K/VMuQE0GNpLLpOuVey6f1WKn3Xj0qvhx/wC
         ZBLDa83Kz6hWWl7lnhTstMwCeLAh2atxYwuXdattXEgZFZNuThX+01WFiMZOkpGPgcYS
         w4uKnP9OQVGZaqGMczzfCWylN+RnZMn0UCQl/f7HCWI8rm11PjfHGPCGknWy3qUC8K6u
         48sbInq9Pmqe36xc/l4fTChdIqbuqYU8PwQDli+jNQwrr5n9t4NwyJ809JaXuSq3o4UN
         al+BbiK+d3IlhEYJIVqgLTbbZZa0TtVpovy+/ovS3eGKHaRLAHbWxtB2auzqe3fvJRSc
         f2QA==
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Received: by 10.66.75.228 with SMTP id f4mr18816761paw.52.1345915512195; Sat,
 25 Aug 2012 10:25:12 -0700 (PDT)
Received: by 10.68.134.102 with HTTP; Sat, 25 Aug 2012 10:25:12 -0700 (PDT)
In-Reply-To: <1345910966.9829.9.camel@rook>
References: <1345910966.9829.9.camel@rook>
Date: Sat, 25 Aug 2012 19:25:12 +0200
Message-ID: <CA+NrkpcfkeRwK52bih3VA6W7uf4-FtCs2=KQJ64mdK4BwmEPLg@mail.gmail.com>
Subject: Re: [gentoo-dev] [RFC] new vala.eclass
From: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= <tomas.chvatal@gmail.com>
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=UTF-8
X-Archives-Salt: 6fec26c9-aec8-4343-bc90-df07923ac091
X-Archives-Hash: 5fdaca22959bc94fe40fdcf4ce771b7f

2012/8/25 Alexandre Rostovtsev <tetromino@gentoo.org>:
Hi man,

*snip*
>
> case "${EAPI:-0}" in
>         0|1|2)
>                 die "EAPI=${EAPI} is not supported"
>                 ;;
>         *)
>                 EXPORT_FUNCTIONS pkg_setup
>                 ;;
> esac

Any reson for not supporting ALL known eapis?

*snip*
>         if [[ -z "${VALA_API_VERSION}" ]]; then
>                 die "VALA_API_VERSION not set"
>         fi
You can use the && instead of conditional as you have longer lines in
the file anyway

*snip*
>         if ! [[ -d "${T}/pkgconfig" ]]; then
>                 mkdir "${T}/pkgconfig" || die "mkdir failed"
>         fi
Same as above

*snip*
>         local p
You should put the var defs on the top, I know this aint ansi C but i
found that we tend to loose the variable declarations in long run
otherwise.

Cheers

Tom