From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id C4A6C1381F3 for ; Wed, 21 Nov 2012 15:28:20 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 46D4021C02E; Wed, 21 Nov 2012 15:28:12 +0000 (UTC) Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 715B621C01D for ; Wed, 21 Nov 2012 15:27:40 +0000 (UTC) Received: by mail-pa0-f53.google.com with SMTP id hz1so1582936pad.40 for ; Wed, 21 Nov 2012 07:27:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=J5YUD3Au6SNGnWBACazuieXPye28DKqoDERedBjxNlQ=; b=ikgPEWzHujCYSPHkXf6HephrEwYwEICMQoaaWnGbGXl+WOBWVqdsWBr+aAtxnw0IGA 4cL6v7HDv+ghIZOpZgXTevyp0qRdc08v+14jlg1lq/slRWVsm48SMI1y8Wlaksujb3+I kHssMbPn6V/suxYYpVbpDfo+eDzXZYU7SpBJkQOOuJjkKS4n0xblHQp0petiBRlZ+eeJ QPqITADRrhJ5NIRGeNcPjCQ8IYDyURH2y36MBFLOIsb2QURsGRV5JKCMtoCSmMaz7t/v qLaqqTqxhpUY4yxaL/s1gVHRC6JKlcFCyK5ZA2C8DeB9w0RLqLPMCV50NrilZqkrIrbl zOww== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Received: by 10.66.73.226 with SMTP id o2mr18325787pav.83.1353511659288; Wed, 21 Nov 2012 07:27:39 -0800 (PST) Received: by 10.68.38.162 with HTTP; Wed, 21 Nov 2012 07:27:39 -0800 (PST) In-Reply-To: <1353265590.23950.13.camel@kanae> References: <1353265590.23950.13.camel@kanae> Date: Wed, 21 Nov 2012 16:27:39 +0100 Message-ID: Subject: Re: [gentoo-dev] gstreamer eclass review From: =?UTF-8?B?VG9tw6HFoSBDaHbDoXRhbA==?= To: gentoo-dev@lists.gentoo.org Content-Type: multipart/alternative; boundary=f46d042f91e6a6b9cb04cf02fd82 X-Archives-Salt: 5149e958-c5de-4383-8af9-aa04187d3e99 X-Archives-Hash: 4322df0da36fabebb2865af8a473b080 --f46d042f91e6a6b9cb04cf02fd82 Content-Type: text/plain; charset=UTF-8 Hi Gilles, The eclass itself looks fine, I would just ask if you would not mind to use the bash += syntax rather than VAR="VAR something" as it is shorter and easier to read. Cheers Tom --f46d042f91e6a6b9cb04cf02fd82 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Gilles,=

The eclass itself looks fine, I would just ask if you would not m= ind to use the bash +=3D syntax rather than VAR=3D"VAR something"= as it is shorter and easier to read.

Che= ers

Tom
--f46d042f91e6a6b9cb04cf02fd82--