From: "Tomáš Chvátal" <tomas.chvatal@gmail.com>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] gstreamer eclass review
Date: Wed, 21 Nov 2012 16:27:39 +0100 [thread overview]
Message-ID: <CA+NrkpcOwZe3fQBpTDeOydO1XKVMB4MMzpcUjjjgv=R7-Zoqhg@mail.gmail.com> (raw)
In-Reply-To: <1353265590.23950.13.camel@kanae>
[-- Attachment #1: Type: text/plain, Size: 189 bytes --]
Hi Gilles,
The eclass itself looks fine, I would just ask if you would not mind to use
the bash += syntax rather than VAR="VAR something" as it is shorter and
easier to read.
Cheers
Tom
[-- Attachment #2: Type: text/html, Size: 742 bytes --]
next prev parent reply other threads:[~2012-11-21 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-18 19:06 [gentoo-dev] gstreamer eclass review Gilles Dartiguelongue
2012-11-18 20:45 ` [gentoo-dev] " Duncan
2012-11-18 22:59 ` Gilles Dartiguelongue
2012-11-19 4:23 ` Duncan
2012-11-18 23:13 ` Alec Warner
2012-11-21 15:27 ` Tomáš Chvátal [this message]
2012-11-21 20:54 ` [gentoo-dev] " Gilles Dartiguelongue
2012-12-06 4:01 ` Maxim Kammerer
2012-12-06 8:40 ` Gilles Dartiguelongue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+NrkpcOwZe3fQBpTDeOydO1XKVMB4MMzpcUjjjgv=R7-Zoqhg@mail.gmail.com' \
--to=tomas.chvatal@gmail.com \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox