From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 5A9301387B1 for ; Sun, 20 Sep 2015 23:54:52 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 6413BE08B0; Sun, 20 Sep 2015 23:54:43 +0000 (UTC) Received: from BLU004-OMC1S22.hotmail.com (blu004-omc1s22.hotmail.com [65.55.116.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 74A53E08A1 for ; Sun, 20 Sep 2015 23:54:42 +0000 (UTC) Received: from BLU436-SMTP196 ([65.55.116.8]) by BLU004-OMC1S22.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Sun, 20 Sep 2015 16:54:41 -0700 X-TMN: [YwyexPnBFEXRB7GxFSKYjDO7eKO5O7mq] X-Originating-Email: [frodriguez.developer@outlook.com] Message-ID: From: Fernando Rodriguez To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Github PR commenting policy Date: Sun, 20 Sep 2015 19:53:52 -0400 User-Agent: KMail/4.14.8 (Linux/4.3.0-rc1; KDE/4.14.8; x86_64; ; ) In-Reply-To: <20150921000028.286ebf9f@symphony.aura-online.co.uk> References: <20150921000028.286ebf9f@symphony.aura-online.co.uk> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-OriginalArrivalTime: 20 Sep 2015 23:54:41.0278 (UTC) FILETIME=[B764A1E0:01D0F3FF] X-Archives-Salt: 4312e75c-1ec6-4404-bd87-e0e62026b53e X-Archives-Hash: beaf819b0c29fe054bff61b3ec13b304 On Monday, September 21, 2015 12:00:28 AM James Le Cuirot wrote: > On Sun, 20 Sep 2015 18:54:24 -0400 > Fernando Rodriguez wrote: >=20 > > On Sunday, September 20, 2015 11:33:34 PM James Le Cuirot wrote: > > > On Sun, 20 Sep 2015 17:53:25 -0400 > > > Fernando Rodriguez wrote: > > >=20 > > > > On Saturday, September 19, 2015 7:31:11 AM Micha=C5=82 G=C3=B3r= ny wrote: > > > > > Dnia 2015-09-18, o godz. 20:09:16 > > > > > Fernando Rodriguez > > > > > napisa=C5=82(a): > > > > >=20 > > > > > > Github allows editting of comments in pull requests. Is the= re > > > > > > a policy regarding that? I've noticed a comment disappear > > > > > > which makes the rest of the=20 > > > > > > conversation seem out of place. > > > > >=20 > > > > > We can't really do anything about that. However, we might soo= n > > > > > be mirroring all comments on Bugzilla where removing comments= > > > > > is not permitted. > > > >=20 > > > > I realize you can't control how users use that feature but ther= e > > > > should be some policy about how developers use it. I opened at = PR > > > > because I was asked in bugzilla. I received some suggestions to= > > > > which I replied that most of them are not related to my PR but > > > > will still do them. After I pushed the changes the comment maki= ng > > > > the suggestions gets deleted. > > >=20 > > > They are probably not deleted but merely hidden. There should be = a > > > "Show outdated diff" link that will reveal them. > >=20 > > Are you refering to the "Show Obsolete" link on Bugzilla? I'm talki= ng > > about deleted comments on Github. I can't find anyway to show them.= >=20 > No, I do mean GitHub. I believe deleted comments really do get delete= d > but the ones that seemingly disappear when you amend a commit just ge= t > hidden. See this pull request as an example. >=20 > https://github.com/chef-cookbooks/enterprise-chef-common/pull/25 >=20 > Notice the grey "Show outdated diff" links on right right. I was refering to actual comments, but that's another annoyance. I thin= k that=20 link is only shown when somebody references the commit. Mine just disap= pear=20 when I amend a commit. Maybe the QA bot could reference every commit. --=20 Fernando Rodriguez