public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org,Michael Haubenwallner <haubi@gentoo.org>
Subject: Re: [gentoo-dev] Re: Can pkg_nofetch determine if a file is already downloaded?
Date: Wed, 17 Oct 2018 16:14:37 +0000	[thread overview]
Message-ID: <B4AD8F2C-E390-431F-A41A-1F59C07BA7BC@gentoo.org> (raw)
In-Reply-To: <bd950b2f-8160-343b-c61f-e98a753cc6c6@gentoo.org>

Dnia October 17, 2018 4:03:17 PM UTC, Michael Haubenwallner <haubi@gentoo.org> napisał(a):
>On 10/15/2018 08:05 PM, Michał Górny wrote:
>> On Mon, 2018-10-15 at 13:34 +0200, Michael Haubenwallner wrote:
>>> Hi,
>>>
>>> in pkg_nofetch, beyond to "direct the user to download relevant
>source files",
>>> I've found it useful to tell the user which filesystem directory to
>put the
>>> files into once downloaded.
>>>
>>> Beyond that, I've also found it useful to tell the user whether a
>relevant
>>> source file is 'already there' or 'still missing'.
>>>
>>> Since the EAPI 6 related update to pkg_* phases to not have access
>to DISTDIR
>>> (even in earlier EAPI) any more, I'm wondering if both informations
>are still
>>> available to pkg_nofetch in one or another way.
>>>
>>> Any idea?
>>>
>>> Or is my only option to reduce the information to "all these files
>need to be
>>> put in your DISTDIR", requiring the user to find out both the right
>DISTDIR
>>> and which of the listed files are still missing herself?
>>>
>> 
>> How would you know whether the file in DISTDIR is correct and
>complete?
>> 
>Well, pkg_nofetch is called only if some files are still missing,
>so portage really should have checked them before, and eventually
>renamed invalid files to "checksum_failure", no?

Maybe. That's entirely undefined behavior.

>
>/haubi/


--
Best regards, 
Michał Górny


  reply	other threads:[~2018-10-17 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-15 11:34 [gentoo-dev] Can pkg_nofetch determine if a file is already downloaded? Michael Haubenwallner
2018-10-15 15:57 ` Ulrich Mueller
2018-10-15 18:05 ` Michał Górny
2018-10-17 16:03   ` [gentoo-dev] " Michael Haubenwallner
2018-10-17 16:14     ` Michał Górny [this message]
2018-10-18 13:34       ` Kent Fredric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B4AD8F2C-E390-431F-A41A-1F59C07BA7BC@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=haubi@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox