[gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[alexey+gentoo]

From: Alexey Sokolov <alexey+gentoo@asokolov.org>

Rationale:

src_test() {
  virtx distutils-r1_src_test
}

If the test fails with "die", Xvfb keeps running forever; but it's
cleaned up correctly with die -n

Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
---
 eclass/distutils-r1.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
index 371d52bcb7e..8896768d3ce 100644
--- a/eclass/distutils-r1.eclass
+++ b/eclass/distutils-r1.eclass
@@ -1,4 +1,4 @@
-# Copyright 1999-2022 Gentoo Authors
+# Copyright 1999-2023 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 # @ECLASS: distutils-r1.eclass
@@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
 	esac
 
 	if [[ ${?} -ne 0 ]]; then
-		die "Tests failed with ${EPYTHON}"
+		die -n "Tests failed with ${EPYTHON}"
 	fi
 }
 
-- 
2.38.2

Re: [gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[Michał Górny]

On Fri, 2023-01-06 at 00:20 +0000, alexey+gentoo@asokolov.org wrote:
> From: Alexey Sokolov <alexey+gentoo@asokolov.org>
> 
> Rationale:
> 
> src_test() {
>   virtx distutils-r1_src_test
> }
> 
> If the test fails with "die", Xvfb keeps running forever; but it's
> cleaned up correctly with die -n
> 
> Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
> ---
>  eclass/distutils-r1.eclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 371d52bcb7e..8896768d3ce 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2022 Gentoo Authors
> +# Copyright 1999-2023 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  # @ECLASS: distutils-r1.eclass
> @@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
>  	esac
>  
>  	if [[ ${?} -ne 0 ]]; then
> -		die "Tests failed with ${EPYTHON}"
> +		die -n "Tests failed with ${EPYTHON}"
>  	fi
>  }
>  

LGTM.  I need to think if we have any changes pending.

-- 
Best regards,
Michał Górny

Re: [gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[Toralf Förster]

[-- Attachment #1.1: Type: text/plain, Size: 356 bytes --]

On 1/6/23 01:20, alexey+gentoo@asokolov.org wrote:
> If the test fails with "die", Xvfb keeps running forever; but it's
> cleaned up correctly with die -n

At my tinderbox I do experience sometimes a running dirmngr process 
solely running since days. /me wonders if that's the result of a similar 
scenario?

-- 
Toralf
PGP 23217DA7 9B888F45


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: [gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[Michał Górny]

On Fri, 2023-01-06 at 16:27 +0100, Toralf Förster wrote:
> On 1/6/23 01:20, alexey+gentoo@asokolov.org wrote:
> > If the test fails with "die", Xvfb keeps running forever; but it's
> > cleaned up correctly with die -n
> 
> At my tinderbox I do experience sometimes a running dirmngr process 
> solely running since days. /me wonders if that's the result of a similar 
> scenario?
> 

Normally it shouldn't be happening since Portage uses PID namespace to
kill all leftover processes.

-- 
Best regards,
Michał Górny

Re: [gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[Sam James]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]



> On 6 Jan 2023, at 16:31, Michał Górny <mgorny@gentoo.org> wrote:
> 
> On Fri, 2023-01-06 at 16:27 +0100, Toralf Förster wrote:
>> On 1/6/23 01:20, alexey+gentoo@asokolov.org wrote:
>>> If the test fails with "die", Xvfb keeps running forever; but it's
>>> cleaned up correctly with die -n
>> 
>> At my tinderbox I do experience sometimes a running dirmngr process
>> solely running since days. /me wonders if that's the result of a similar
>> scenario?
>> 
> 
> Normally it shouldn't be happening since Portage uses PID namespace to
> kill all leftover processes.
> 

Yeah, this is mainly an issue on e.g. prefix or containers.

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]

Re: [gentoo-dev] [PATCH v2] distutils-r1.eclass: support nonfatal in test

[Michał Górny]

On Fri, 2023-01-06 at 00:20 +0000, alexey+gentoo@asokolov.org wrote:
> From: Alexey Sokolov <alexey+gentoo@asokolov.org>
> 
> Rationale:
> 
> src_test() {
>   virtx distutils-r1_src_test
> }
> 
> If the test fails with "die", Xvfb keeps running forever; but it's
> cleaned up correctly with die -n
> 
> Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
> ---
>  eclass/distutils-r1.eclass | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/eclass/distutils-r1.eclass b/eclass/distutils-r1.eclass
> index 371d52bcb7e..8896768d3ce 100644
> --- a/eclass/distutils-r1.eclass
> +++ b/eclass/distutils-r1.eclass
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2022 Gentoo Authors
> +# Copyright 1999-2023 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  # @ECLASS: distutils-r1.eclass
> @@ -1559,7 +1559,7 @@ distutils-r1_python_test() {
>  	esac
>  
>  	if [[ ${?} -ne 0 ]]; then
> -		die "Tests failed with ${EPYTHON}"
> +		die -n "Tests failed with ${EPYTHON}"
>  	fi
>  }
>  

Merged now.

-- 
Best regards,
Michał Górny