From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id B3C081382C5 for ; Thu, 1 Apr 2021 21:58:04 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 65EC5E0900; Thu, 1 Apr 2021 21:58:01 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7D1FCE08FB for ; Thu, 1 Apr 2021 21:58:00 +0000 (UTC) From: Sam James Content-Type: multipart/signed; boundary="Apple-Mail=_793B02C3-5247-480E-9751-40AA8B74044B"; protocol="application/pgp-signature"; micalg=pgp-sha512 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.60.0.2.21\)) Subject: Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in To: gentoo-dev@lists.gentoo.org In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3654.60.0.2.21) X-Archives-Salt: ea0b773c-a84f-4143-b7da-0641a11e71a7 X-Archives-Hash: cdc4354c2838086aaca423b7f4bc151c --Apple-Mail=_793B02C3-5247-480E-9751-40AA8B74044B Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 31 Mar 2021, at 10:09, Ulrich Mueller wrote: >=20 >>>>>> On Wed, 31 Mar 2021, Andreas Sturmlechner wrote: >=20 >> setup-allowed-flags() { >> + [[ ${EAPI} =3D=3D [0-7] ]] || >> + die "Internal function ${FUNCNAME} is not available in = >=3DEAPI-8." >> + _setup-allowed-flags >> +} >=20 > Strictly speaking, EAPIs are strings, so numeric comparison is not > meaningful. Suggestion: "... is not available in EAPI ${EAPI}." That=E2=80=99s a reason to not do arithmetic comparison in e.g. Bash, = but >=3D refers to age/chronological order here, which isn=E2=80=99t a problem. >=20 >> test-flag-PROG() { >> + [[ ${EAPI} =3D=3D [0-7] ]] || >> + die "Internal function ${FUNCNAME} is not available in = >=3DEAPI-8." >> + _test-flag-PROG >> +} >=20 >> test-flags-PROG() { >> + [[ ${EAPI} =3D=3D [0-7] ]] || >> + die "Internal function ${FUNCNAME} is not available in = >=3DEAPI-8." >> + _test-flags-PROG >> +} >=20 > Same for these. >=20 > Ulrich --Apple-Mail=_793B02C3-5247-480E-9751-40AA8B74044B Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEEYOpPv/uDUzOcqtTy9JIoEO6gSDsFAmBmQeFfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDYw RUE0RkJGRkI4MzUzMzM5Q0FBRDRGMkY0OTIyODEwRUVBMDQ4M0IACgkQ9JIoEO6g SDsTIAf8COXjKtOfRKSQWfAD+MRrNABY5ROY0n3N4Td1+HRlMSTLfLAe60Saea2h kAfOf1M0kRdgf/y7fJJtfFhWPLDZPtEp28WRdKb8p83WGWRBE6QHekAJhiyWCUTH wZ5xpOXwXd2WsQGFyX9W8A8gpijH6DdArhGnvBkhJin4jRIYQoPbUh/MlTakIUNB IlHBcLg+lAPnnXqiyGVE5FRCnf+VAQL7f/GXrE3FyhSJk9yclhg19VCuWuuo60hv aD0KZH+M/rAAeL3wAerTn9cYNcCY2GLwIdz0KAfNUP7RYTJaUiAlVRwKtIgx8ZV8 EbbhKmZFgIOPGFTfyMsaM8F2miSumg== =zSmu -----END PGP SIGNATURE----- --Apple-Mail=_793B02C3-5247-480E-9751-40AA8B74044B--