public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* Re: [gentoo-dev] rfc: calling all eclass phase functions by default
  @ 2014-08-17  7:23 99%       ` "Paweł Hajdan, Jr."
  0 siblings, 0 replies; 1+ results
From: "Paweł Hajdan, Jr." @ 2014-08-17  7:23 UTC (permalink / raw
  To: gentoo-dev

[-- Attachment #1: Type: text/plain, Size: 905 bytes --]

On 8/17/14, 9:18 AM, Michał Górny wrote:
> Dnia 2014-08-17, o godz. 09:06:04
> "Paweł Hajdan, Jr." <phajdan.jr@gentoo.org> napisał(a):
>> The warning would make the problem more visible to ebuild writers. Then
>> we already have a solution that works, i.e. explicitly defining the
>> phase function in the ebuild, possibly calling the eclass functions.
>>
>> My understanding is people not being aware of the problem is the main
>> issue here, not the ability to address it.
> 
> What we could do is printing the phase function names when starting
> them, e.g.:
> 
>   >>> [foo_src_compile] Compiling sources in ...
> 
> As for another idea, we could warn if an eclass overrides phase
> function via implicit inherit without redefining it. As I see it, this
> is the biggest issue here, and a solution that's relatively easy to
> accept.

Both of these sound good to me.

Paweł



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 841 bytes --]

^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2014-08-16 21:54     [gentoo-dev] rfc: calling all eclass phase functions by default William Hubbs
2014-08-16 22:32     ` Kent Fredric
2014-08-17  7:06       ` "Paweł Hajdan, Jr."
2014-08-17  7:18         ` Michał Górny
2014-08-17  7:23 99%       ` "Paweł Hajdan, Jr."

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox