* Re: [gentoo-dev] [PATCH] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
@ 2019-12-31 8:28 99% ` David Seifert
0 siblings, 0 replies; 1+ results
From: David Seifert @ 2019-12-31 8:28 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
On Tue, 2019-12-31 at 05:34 +0100, Michał Górny wrote:
> Using 2-style USE dependencies on packages not having the flag
> in question is forbidden by PMS.
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> eclass/ruby-ng.eclass | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
> index db701d81f4fc..c2b9442ef489 100644
> --- a/eclass/ruby-ng.eclass
> +++ b/eclass/ruby-ng.eclass
> @@ -137,7 +137,7 @@ ruby_samelib() {
> local res=
> for _ruby_implementation in $(_ruby_get_all_impls); do
> has -${_ruby_implementation} $@ || \
> - res="${res}ruby_targets_${_ruby_implementation}
> ?,"
> + res="${res}ruby_targets_${_ruby_implementation}
> ?(-),"
https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-830008.3.4
In a 4-style use dependency, the flag name may *immediately* be
followed by a default specified by either (+) or (-)
https://github.com/gentoo-mirror/gentoo/blob/stable/metadata/md5-cache/dev-libs/boost-1.72.0
>=dev-python/numpy-1.17[python_targets_python3_6(-)?,...]
Given that you ran this through CI, this smells of dead code...
> done
>
> echo "[${res%,}]"
> @@ -151,9 +151,9 @@ _ruby_atoms_samelib_generic() {
> "||" | "(" | ")" | *"?")
> echo "${token}" ;;
> *])
> - echo
> "${token%[*}[RUBYTARGET,${token/*[}" ;;
> + echo "${token%[*}[RUBYTARGET(-
> ),${token/*[}" ;;
> *)
> - echo "${token}[RUBYTARGET]" ;;
> + echo "${token}[RUBYTARGET(-)]" ;;
> esac
> done
> echo ")"
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-12-31 4:34 [gentoo-dev] [PATCH] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies Michał Górny
2019-12-31 8:28 99% ` David Seifert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox