public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* Re: [gentoo-dev] [PATCH 1/3] python-any-r1.eclass: Constrain to EAPI >= 5
  @ 2019-12-14 11:29 99% ` Ulrich Mueller
  0 siblings, 0 replies; 1+ results
From: Ulrich Mueller @ 2019-12-14 11:29 UTC (permalink / raw
  To: David Seifert; +Cc: gentoo-dev, python

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

>>>>> On Sat, 14 Dec 2019, David Seifert wrote:

>  case "${EAPI:-0}" in
> -	0|1|2|3|4|5|6|7)
> +	[01234])
> +		die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
> +		;;
> +	[567])
>  		;;
>  	*)
>  		die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"

I know that this exists in other eclasses as well, but do we really need
that distinction in the error message for "too old" and "unknown" EAPIs?
It should be pretty clear which case applies there, especially since the
message is addressed at developers, not users.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2019-12-14 10:50     [gentoo-dev] [PATCH 1/3] python-any-r1.eclass: Constrain to EAPI >= 5 David Seifert
2019-12-14 11:29 99% ` Ulrich Mueller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox