* Re: [gentoo-dev] [RFC] qmail.eclass draft
@ 2007-07-20 9:52 99% ` Michael Hanselmann
0 siblings, 0 replies; 1+ results
From: Michael Hanselmann @ 2007-07-20 9:52 UTC (permalink / raw
To: gentoo-dev; +Cc: hollow
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
Hello Benedikt
On Fri, Jul 13, 2007 at 01:37:11PM +0200, Benedikt Boehm wrote:
> It is basically netqmail split into much smaller chunks so they can be
> reused by other qmail variants as well.
Okay, I looked through it and found some things which need
reconsideration. I agree that user creation and such things can be
easily done in an eclass. However, functions like qmail_src_unpack
should be done in the ebuild. Putting them in an eclass and just doing
"if (a) { … } else if (b) { … }" makes it harder to understand and
unneccessarily complicated. qmail_base_install should be split in
smaller functions, maybe with callbacks (if possible in bash). In the
end the ebuild shouldn't contain any package-specific code. Can you look
into it again?
Greets,
Michael
--
http://hansmi.ch/
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2007-07-13 11:37 [gentoo-dev] [RFC] qmail.eclass draft Benedikt Boehm
2007-07-20 9:52 99% ` Michael Hanselmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox