public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* Re: [gentoo-dev] New eclass: oasis.eclass for oasis-based ocaml packages.
  @ 2012-03-23 18:03 99%   ` Alexis Ballier
  0 siblings, 0 replies; 1+ results
From: Alexis Ballier @ 2012-03-23 18:03 UTC (permalink / raw
  To: gentoo-dev

On Fri, 23 Mar 2012 11:58:47 -0400
Mike Gilbert <floppym@gentoo.org> wrote:

> On Fri, Mar 23, 2012 at 4:15 AM, Alexis Ballier <aballier@gentoo.org>
> wrote:
> 
> > DEPEND=">=dev-lang/ocaml-3.12[ocamlopt?]"
> > DEPEND="${RDEPEND}"
> 
> That looks like a typo.

yes, thanks for spotting

> 
> > oasis_src_compile() {
> > 	oasis_src_compile_no_doc
> > 	if has doc ${IUSE} && use doc; then
> > 		ocaml setup.ml -doc || die
> > 	fi
> > }
> 
> This should probably call use_if_iuse from eutils.eclass, which
> handles IUSE="[+-]doc".
> 

hmm, actually, I like the idea of something like OASIS_WANT_DOCS as
suggested by Ciaran, this sounds simpler and, as a side effect, will
allow me to kill the useless oasis_src_compile_no_doc function.

I'll come back with something like this and post an update, most likely
next week, pilling up the reviews :=)


A.



^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2012-03-23  8:15     [gentoo-dev] New eclass: oasis.eclass for oasis-based ocaml packages Alexis Ballier
2012-03-23 15:58     ` Mike Gilbert
2012-03-23 18:03 99%   ` Alexis Ballier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox