public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* Re: [gentoo-dev] [PATCH git-2.eclass 1/2] Clean up non-bare checkout before updating.
  @ 2011-12-23 21:49 99%   ` Michał Górny
  0 siblings, 0 replies; 1+ results
From: Michał Górny @ 2011-12-23 21:49 UTC (permalink / raw
  To: gentoo-dev; +Cc: ulm

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

On Fri, 23 Dec 2011 22:09:26 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:

> >>>>> On Fri, 23 Dec 2011, Michał Górny wrote:
> 
> > Fixes: https://bugs.gentoo.org/show_bug.cgi?id=395247
> 
> > +		git clean -d -f -x || die "${FUNCNAME}: failed to
> > clean checkout dir" +
> 
> Why should there be untracked files, in the first place? (In the
> "steps to reproduce" of bug 395247 such files are explicitly generated
> by the user, which doesn't look like a valid usage case to me.)

Yes, it is invalid. Yet I think it's better to clean up just in case
upstream pulling gone wrong (e.g. when upstream does rebase).

-- 
Best regards,
Michał Górny

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 316 bytes --]

^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2011-12-23 14:34     [gentoo-dev] [PATCH git-2.eclass 1/2] Clean up non-bare checkout before updating Michał Górny
2011-12-23 21:09     ` Ulrich Mueller
2011-12-23 21:49 99%   ` Michał Górny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox