* [gentoo-dev] perl-module.eclass -- review
@ 2009-02-27 14:08 99% Torsten Veller
0 siblings, 0 replies; 1+ results
From: Torsten Veller @ 2009-02-27 14:08 UTC (permalink / raw
To: gentoo-dev; +Cc: gentoo-perl
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
Please review the attached perl-module.eclass.
Patch linked below.
Changes (#239510):
~~~~~~~
- EAPI 2 support
- default license
- reduced EXPORT_FUNCTIONS for EAPI=2
- HOMEPAGE changed
- LDFLAGS support
- quoting
- removes updatepod()
- removes .packlist files
- removes empty *.bs files
- removed BUILDER_VER stuff
IDEAS
~~~~~
- remove esvn_clean
- cache perlinfo calls
TODO (no showstopper)
~~~~
- still no documentation
- perl-app.eclass not done
After that perl-module_src_prep calls in ebuilds should be updated
(perl-module_src_configure) or removed:
| app-pda/pilot-link
| dev-perl/GDTextUtil
| dev-tex/html2latex
| kde-base/dcopperl
| mail-filter/spamassassin
| sci-libs/gdal
| sci-libs/udunit
Ebuilds with a local perl-module_src_prep function should be fixed too
| dev-perl/Alien-wxWidgets
| dev-perl/HTML-Mason
| www-apps/Embperl/Embperl
git://github.com/tove/perl-eclass.git
http://people.gentoo.org/tove/files/perl-module.eclass.diff
[-- Attachment #2: perl-module.eclass --]
[-- Type: text/plain, Size: 5028 bytes --]
# Copyright 1999-2004 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2
# $Header: /var/cvsroot/gentoo-x86/eclass/perl-module.eclass,v 1.112 2008/09/30 08:28:44 robbat2 Exp $
#
# Author: Seemant Kulleen <seemant@gentoo.org>
# @ECLASS: perl-module.eclass
# @MAINTAINER:
# perl@gentoo.org
# @BLURB: eclass for perl modules
# @DESCRIPTION:
# The perl-module eclass is designed to allow easier installation of perl
# modules, and their incorporation into the Gentoo Linux system.
inherit eutils base
case "${EAPI:-0}" in
0|1)
EXPORT_FUNCTIONS pkg_setup pkg_preinst pkg_postinst pkg_prerm pkg_postrm src_compile src_install src_test src_unpack
;;
*)
EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_test src_install
;;
esac
DESCRIPTION="Based on the $ECLASS eclass"
LICENSE="${LICENSE:-|| ( Artistic GPL-2 )}"
[ -z "${SRC_URI}" -a -z "${MODULE_A}" ] && MODULE_A="${MY_P:-${P}}.tar.gz"
[ -z "${SRC_URI}" -a -n "${MODULE_AUTHOR}" ] && \
SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION}/${MODULE_A}"
[ -z "${HOMEPAGE}" ] && \
HOMEPAGE="http://search.cpan.org/dist/${MY_PN:-${PN}}"
SRC_PREP="no"
SRC_TEST="skip"
PREFER_BUILDPL="yes"
PERL_VERSION=""
SITE_ARCH=""
SITE_LIB=""
VENDOR_LIB=""
VENDOR_ARCH=""
ARCH_LIB=""
pm_echovar=""
perl-module_src_unpack() {
base_src_unpack unpack
has "${EAPI:-0}" 0 1 && perl-module_src_prepare
}
perl-module_src_prepare() {
if [[ -n ${PATCHES} ]] ; then
base_src_unpack autopatch
fi
esvn_clean
}
perl-module_src_configure() {
perl-module_src_prep
}
perl-module_src_prep() {
[[ "${SRC_PREP}" = "yes" ]] && return 0
SRC_PREP="yes"
perlinfo
export PERL_MM_USE_DEFAULT=1
# Disable ExtUtils::AutoInstall from prompting
export PERL_EXTUTILS_AUTOINSTALL="--skipdeps"
if [[ "${PREFER_BUILDPL}" == "yes" && -f Build.PL ]] ; then
einfo "Using Module::Build"
perl Build.PL \
--installdirs vendor \
--libdoc= \
--config installman3dir= \
--destdir "${D}" \
--create_packlist=0 \
--extra_linker_flags="${LDFLAGS}" \
${myconf} \
<<< ${pm_echovar} \
|| die "Unable to build! (are you using USE=\"build\"?)"
elif [[ -f Makefile.PL ]] ; then
einfo "Using ExtUtils::MakeMaker"
perl Makefile.PL \
PREFIX=/usr \
INSTALLDIRS=vendor \
INSTALLMAN3DIR='none' \
DESTDIR="${D}" \
${myconf} \
<<< ${pm_echovar} \
|| die "Unable to build! (are you using USE=\"build\"?)"
fi
if [[ ! -f Build.PL && ! -f Makefile.PL ]] ; then
einfo "No Make or Build file detected..."
return
fi
}
perl-module_src_compile() {
perlinfo
has "${EAPI:-0}" 0 1 && perl-module_src_prep
if [[ -f Build ]] ; then
./Build build || die "compilation failed"
elif [[ -f Makefile ]] ; then
#make ${mymake} OPTIMIZE="${CFLAGS}" OTHERLDFLAGS="${LDFLAGS}" || die "compilation failed"
make ${mymake} OTHERLDFLAGS="${LDFLAGS}" || die "compilation failed"
fi
}
perl-module_src_test() {
if [[ "${SRC_TEST}" == "do" ]] ; then
perlinfo
if [[ -f Build ]] ; then
./Build test || die "test failed"
elif [[ -f Makefile ]] ; then
make test || die "test failed"
fi
fi
}
perl-module_src_install() {
local f stat
perlinfo
[[ -z ${mytargets} ]] && mytargets="pure_install"
if [[ -f Build ]] ; then
./Build ${mytargets} || die
elif [[ -f Makefile ]] ; then
make ${myinst} ${mytargets} || die
fi
einfo "Cleaning out stray man files"
for f in $(find "${D}" -type f -name "*.3pm*" ) ; do
#einfo "Cleaning stray man files: ${f##*/}"
rm -f "${f}"
done
find "${D}"/usr/share/man -depth -type d -empty -delete 2>/dev/null
fixlocalpod
for f in Change* CHANGES README* ${mydoc}; do
[[ -s "${f}" ]] && dodoc ${f}
done
find "${D}/${VENDOR_LIB}" -type f -a \( -name .packlist \
-o \( -name '*.bs' -a -empty \) \) -delete
find "${D}/${VENDOR_LIB}" -depth -mindepth 1 -type d -empty -delete
for f in $(find "${D}" -type f -not -name '*\.so' ) ; do
stat=$(file "${f}" | grep -i " text" )
if [[ "${stat}x" != "x" ]] ; then
sed -i -e "s:${D}:/:g" "${f}"
fi
done
}
perl-module_pkg_setup() {
perlinfo
}
perl-module_pkg_preinst() {
perlinfo
}
perl-module_pkg_postinst() { : ; }
# einfo "Man pages are not installed for most modules now."
# einfo "Please use perldoc instead."
#}
perl-module_pkg_prerm() { : ; }
perl-module_pkg_postrm() { : ; }
perlinfo() {
local version
eval `perl '-V:version'`
PERL_VERSION=${version}
local installsitearch
eval `perl '-V:installsitearch'`
SITE_ARCH=${installsitearch}
local installsitelib
eval `perl '-V:installsitelib'`
SITE_LIB=${installsitelib}
local installarchlib
eval `perl '-V:installarchlib'`
ARCH_LIB=${installarchlib}
local installvendorlib
eval `perl '-V:installvendorlib'`
VENDOR_LIB=${installvendorlib}
local installvendorarch
eval `perl '-V:installvendorarch'`
VENDOR_ARCH=${installvendorarch}
}
fixlocalpod() {
find "${D}" -type f -name perllocal.pod -delete
find "${D}" -depth -mindepth 1 -type d -empty -delete
}
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2009-02-27 14:08 99% [gentoo-dev] perl-module.eclass -- review Torsten Veller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox