public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* Re: [gentoo-dev] Patch make_desktop_entry to produce entries that validate better
  @ 2007-11-18  0:01 99% ` Petteri Räty
  0 siblings, 0 replies; 1+ results
From: Petteri Räty @ 2007-11-18  0:01 UTC (permalink / raw
  To: gentoo-dev


[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]

Petteri Räty kirjoitti:
> Any objections to the attached patch:
> 
> betelgeuse@pena ~ $ desktop-file-validate
> /usr/share/applications/jedit-jedit.desktop
> /usr/share/applications/jedit-jedit.desktop: warning: key "Encoding" in
> group "Desktop Entry" is deprecated
> /usr/share/applications/jedit-jedit.desktop: warning: value "" for key
> "Path" in group "Desktop Entry" does not look like an absolute path
> 
> Regards,
> Petteri
> 

Hmm. Wrong patch attached.

[-- Attachment #1.2: make_desktop_entry.patch --]
[-- Type: text/plain, Size: 596 bytes --]

Index: eutils.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.292
diff -u -r1.292 eutils.eclass
--- eutils.eclass	14 Oct 2007 21:55:35 -0000	1.292
+++ eutils.eclass	17 Nov 2007 22:53:28 -0000
@@ -882,11 +882,12 @@
 	Comment=${DESCRIPTION}
 	Exec=${exec}
 	TryExec=${exec%% *}
-	Path=${path}
 	Icon=${icon}
 	Categories=${type};
 	EOF
 
+	[[ ${path} ]] && echo "Path=${path}" >> "${desktop}"
+
 	(
 		# wrap the env here so that the 'insinto' call
 		# doesn't corrupt the env of the caller

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2007-11-17 22:53     [gentoo-dev] Patch make_desktop_entry to produce entries that validate better Petteri Räty
2007-11-18  0:01 99% ` Petteri Räty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox