* [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch
[not found] <20140622162511.10F352004F@flycatcher.gentoo.org>
@ 2014-06-22 17:08 99% ` Samuli Suominen
0 siblings, 0 replies; 1+ results
From: Samuli Suominen @ 2014-06-22 17:08 UTC (permalink / raw
To: gentoo-dev, voyageur
On 22/06/14 19:25, Bernard Cafarelli (voyageur) wrote:
> voyageur 14/06/22 16:25:10
>
> Modified: wmfishtime-1.24-gtk.patch
> Log:
> Link with libm, spotted by patrick in bug #513908
>
> (Portage version: 2.2.10/cvs/Linux x86_64, signed Manifest commit with key C74525F2)
>
> Revision Changes Path
> 1.3 x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch
>
> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch?rev=1.3&view=markup
> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch?rev=1.3&content-type=text/plain
> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch?r1=1.2&r2=1.3
>
> Index: wmfishtime-1.24-gtk.patch
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/x11-plugins/wmfishtime/files/wmfishtime-1.24-gtk.patch,v
> retrieving revision 1.2
> retrieving revision 1.3
> diff -u -r1.2 -r1.3
> --- wmfishtime-1.24-gtk.patch 6 Jun 2011 20:04:49 -0000 1.2
> +++ wmfishtime-1.24-gtk.patch 22 Jun 2014 16:25:10 -0000 1.3
> @@ -48,7 +48,7 @@
> SHELL = sh
> OBJS = fishmon.o
> -LIBS = `gtk-config --libs | sed "s/-lgtk//g"`
> -+LIBS = `pkg-config gtk+-2.0 --libs` -lX11
> ++LIBS = `pkg-config gtk+-2.0 --libs` -lm -lX11
> INSTALL = -m 755
>
> all: wmfishtime
>
>
>
>
> gtk+-2.0 --libs` -lm -lX11
This is wrong, it should be:
PKG_CONFIG ?= pkg-config
LIBS = `$(PKG_CONFIG) gtk+-2.0 --libs` -lm -X11
And ebuild should have `export PKG_CONFIG="$(tc-getPKG_CONFIG)"`
As in, PKG_CONFIG needs to be respected from the environment, it's
almost never O.K. to
hardcode pkg-config
I realize you didn't touch that part of the patch right now, but imho,
these should get fixed
whereever spotted.
Thanks,
Samuli
^ permalink raw reply [relevance 99%]
Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
[not found] <20140622162511.10F352004F@flycatcher.gentoo.org>
2014-06-22 17:08 99% ` [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-plugins/wmfishtime/files: wmfishtime-1.24-gtk.patch Samuli Suominen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox