public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
Search results ordered by [date|relevance]  view[summary|nested|Atom feed]
thread overview below | download: 
* Re: [gentoo-dev] Proposed update to pax-utils.eclass
  @ 2013-03-27 12:39 99%   ` Gilles Dartiguelongue
  0 siblings, 0 replies; 1+ results
From: Gilles Dartiguelongue @ 2013-03-27 12:39 UTC (permalink / raw
  To: gentoo-dev

Le dimanche 24 mars 2013 à 20:20 -0400, Anthony G. Basile a écrit :
> Last call, does anyone have a problem with me updating the 
> pax-utils.eclass?  See Ref [3] above for the code.  I'll wait a couple 
> more days and then do it.

looks like last conditional branch for XT marking in pax-mark function
is not using the proper variables (pt_* instead ot xt_*).

The PAX_MARKINGS variable is not documented with eclass documentation
markup, it should at least get an "@INTERNAL" if this is not supposed to
be modified by eclass users.

_pax_list_files can receive documentation this way as well.

You should probably try to avoid mixing [[ ]] and [ ] in the eclass. [ ]
seems to be less used here so just have everything [[ ]] and drop the
useless quoting that came with [ ].

The rest looks fine.

-- 
Gilles Dartiguelongue <eva@gentoo.org>
Gentoo



^ permalink raw reply	[relevance 99%]

Results 1-1 of 1 | reverse | options above
-- pct% links below jump to the message on this page, permalinks otherwise --
2013-03-17 12:19     [gentoo-dev] Proposed update to pax-utils.eclass Anthony G. Basile
2013-03-25  0:20     ` Anthony G. Basile
2013-03-27 12:39 99%   ` Gilles Dartiguelongue

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox