From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9699B1396D0 for ; Fri, 29 Sep 2017 08:29:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 01CD3E0BB2; Fri, 29 Sep 2017 08:29:09 +0000 (UTC) Received: from atfriesa01.ssi-schaefer.com (atfriesa01.ssi-schaefer.com [193.186.16.100]) by pigeon.gentoo.org (Postfix) with ESMTP id 6D0D8E0AF0 for ; Fri, 29 Sep 2017 08:29:08 +0000 (UTC) X-IronPort-AV: E=Sophos;i="5.42,451,1500933600"; d="scan'208";a="4453507" X-IPAS-Result: =?us-ascii?q?A2FfBAAGA85Z/+shHKxdGQEBAQEBAQEBAQEBBwEBAQEBhEC?= =?us-ascii?q?BFYN4mkQGgSuXekMKI4UYAoRtEwECAQEBAQEBAQOBEIJhBEYpLwEBAQEBAQEBA?= =?us-ascii?q?QEBAQEBARoCDV4BBSNWEAsYAgImAgJXEwYCAQEXigkdpyeCJ4tDAQEBAQEBAQM?= =?us-ascii?q?BAQEBHwWBDoIdgwuCXYJ9hE0XAQFqgkeCQR8FkT6PbYdejQSTB5VOgTk3gS+BB?= =?us-ascii?q?QiGGIFQdIV4D4I0AQEB?= Received: from samail03.wamas.com (HELO mailhost.salomon.at) ([172.28.33.235]) by atfriesa01.ssi-schaefer.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2017 10:29:08 +0200 Received: from s01en24.wamas.com ([172.28.41.101]) by mailhost.salomon.at with esmtp (Exim 4.77) (envelope-from ) id 1dxqfT-0001Pt-6J; Fri, 29 Sep 2017 10:29:07 +0200 From: Michael Haubenwallner Subject: [gentoo-dev] Re: sys-libs/ncurses: erronious deletion of *.dll.a files; possibly other packages affected To: gentoo-dev@lists.gentoo.org References: <20170921020139.kp4664tanr7cj77d@proprietary-killer.fossland> <20170929013637.gz7ntmg4fb62mzel@proprietary-killer.fossland> Cc: "Marty E. Plummer" Message-ID: <9ffbcbe2-fc70-aff9-4a9f-1bcaead3f035@gentoo.org> Date: Fri, 29 Sep 2017 10:29:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20170929013637.gz7ntmg4fb62mzel@proprietary-killer.fossland> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Archives-Salt: 852892ab-5c19-4971-bd8c-1422305745e8 X-Archives-Hash: 9720b0599eb72a84f1e094c321af3f83 On 09/29/2017 03:36 AM, Marty E. Plummer wrote: > On Thu, Sep 28, 2017 at 07:35:20PM +0000, Mike Gilbert wrote: >> On Wed, Sep 20, 2017 at 10:01 PM, Marty E. Plummer >> wrote: >>> arfrever suggests I send a mail here, as there are other packages which >>> may be affected by this issue and perhaps a more generalized fix is >>> required instead of an explicit fix in sys-libs/ncurses and other ebuilds >>> that may require it. >> >> I think the solution here is to remove those overly broad "find >> -delete" statements and replace them with something safer. >> >> Ideally the build system(s) would be patched to not compile static >> libs in the first place. >> >> If that's not possible, perhaps an eclass function could be created to >> safely remove static libs. >> > Honestly I already have a pr up that fixes this particular package's > issue, fairly simple fix https://github.com/gentoo/gentoo/pull/5734 > > --- a/sys-libs/ncurses/ncurses-6.0-r1.ebuild > +++ b/sys-libs/ncurses/ncurses-6.0-r1.ebuild > @@ -241,7 +241,8 @@ multilib_src_install() { > # Provide a link for -lcurses. > ln -sf libncurses$(get_libname) "${ED}"/usr/$(get_libdir)/libcurses$(get_libname) || die > fi > - use static-libs || find "${ED}"/usr/ -name '*.a' -delete > + # don't delete '*.dll.a', needed for linking #631468 > + use static-libs || find "${ED}"/usr/ -name '*.a' ! -name '*.dll.a' -delete In prefix overlay we have this version: use static-libs || find "${ED}"/usr/ -name '*.a' -not -name "*$(get_libname)" -delete /haubi/