[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: www-apps/cgit/

["Michał Górny" <mgorny@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 2411 bytes --]

On Sun, 2019-09-29 at 20:59 +0000, Ben Kohler wrote:
> commit:     23d65596bf6ed47cf5a8fd1d163ddbf3f8fb2ce9
> Author:     Ben Kohler <bkohler <AT> gentoo <DOT> org>
> AuthorDate: Sun Sep 29 20:55:55 2019 +0000
> Commit:     Ben Kohler <bkohler <AT> gentoo <DOT> org>
> CommitDate: Sun Sep 29 20:57:29 2019 +0000
> URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23d65596
> 
> www-apps/cgit: fix missing group on installation
> 
> After a recent change in user.eclass, this package no longer creates
> the required group that's used later in src_install.  I've adjusted the
> ebuilds to restore the original behavior as intended before this eclass
> change.
> 
> https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/user.eclass?id=3afc0d7b8b5e90c50d66c5a845b96c33e521e6e8
> Closes: https://bugs.gentoo.org/688890
> Package-Manager: Portage-2.3.76, Repoman-2.3.17
> RepoMan-Options: --force

What's the justification for using --force?

> Signed-off-by: Ben Kohler <bkohler <AT> gentoo.org>
> 
>  www-apps/cgit/cgit-1.2.1.ebuild | 5 +++--
>  www-apps/cgit/cgit-9999.ebuild  | 5 +++--
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/www-apps/cgit/cgit-1.2.1.ebuild b/www-apps/cgit/cgit-1.2.1.ebuild
> index 82174c82295..4bbbeef07a1 100644
> --- a/www-apps/cgit/cgit-1.2.1.ebuild
> +++ b/www-apps/cgit/cgit-1.2.1.ebuild
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2018 Gentoo Foundation
> +# Copyright 1999-2019 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  EAPI=5
> @@ -38,7 +38,8 @@ DEPEND="${RDEPEND}
>  
>  pkg_setup() {
>  	webapp_pkg_setup
> -	enewuser "${PN}"
> +	enewgroup ${PN}
> +	enewuser ${PN} -1 -1 -1 ${PN}
>  }
>  
>  src_prepare() {
> 
> diff --git a/www-apps/cgit/cgit-9999.ebuild b/www-apps/cgit/cgit-9999.ebuild
> index 28d3a792277..a6df9326558 100644
> --- a/www-apps/cgit/cgit-9999.ebuild
> +++ b/www-apps/cgit/cgit-9999.ebuild
> @@ -1,4 +1,4 @@
> -# Copyright 1999-2018 Gentoo Foundation
> +# Copyright 1999-2019 Gentoo Authors
>  # Distributed under the terms of the GNU General Public License v2
>  
>  EAPI="4"
> @@ -36,7 +36,8 @@ DEPEND="${RDEPEND}
>  
>  pkg_setup() {
>  	webapp_pkg_setup
> -	enewuser "${PN}"
> +	enewgroup ${PN}
> +	enewuser ${PN} -1 -1 -1 ${PN}
>  }
>  
>  src_prepare() {
> 

-- 
Best regards,
Michał Górny


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 618 bytes --]