From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <gentoo-dev+bounces-95150-garchives=archives.gentoo.org@lists.gentoo.org> Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 37E11139360 for <garchives@archives.gentoo.org>; Tue, 3 Aug 2021 11:40:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AD103E0A9A; Tue, 3 Aug 2021 11:40:20 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 4175EE0A90 for <gentoo-dev@lists.gentoo.org>; Tue, 3 Aug 2021 11:40:19 +0000 (UTC) Message-ID: <9ddc7a8337b5bbb4edb3b8ffa76e9e0b17c9eabb.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH v2] xdg.eclass: add EAPI 8 support From: Mart Raudsepp <leio@gentoo.org> To: gentoo-dev@lists.gentoo.org Cc: Florian Schmaus <flow@gentoo.org> Date: Tue, 03 Aug 2021 14:40:16 +0300 In-Reply-To: <20210721150849.175482-1-flow@gentoo.org> References: <20210715111956.297120-1-flow@gentoo.org> <20210721150849.175482-1-flow@gentoo.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-xHvN7ALxA+pLw/Av6R5n" User-Agent: Evolution 3.38.4 Precedence: bulk List-Post: <mailto:gentoo-dev@lists.gentoo.org> List-Help: <mailto:gentoo-dev+help@lists.gentoo.org> List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org> List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org> List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org> X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 63cd71fc-c92e-4525-8afe-9c0bd5971c02 X-Archives-Hash: 73cc82d329e83a279693f3efd4d7f6cc --=-xHvN7ALxA+pLw/Av6R5n Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =C3=9Chel kenal p=C3=A4eval, K, 21.07.2021 kell 17:08, kirjutas Florian Sch= maus: > Note that this removes the export of src_prepare in EPAI 8 as > requested by ionen: >=20 > =C2=A0 1. remove src_prepare export in EAPI-8 >=20 > =C2=A0 While "some" packages need xdg_environment_reset, most don't > because > =C2=A0 the eclass is often only inherited to handle icons/.desktop and > this > =C2=A0 just needlessly overwrite the src_prepare of other eclasses > requiring > =C2=A0 more careful inherit ordering (e.g. inherit xdg cmake). >=20 > =C2=A0 I'd prefer it was clear when a package need this by calling > =C2=A0 xdg_environment_reset directly. Unless there is a non-trivial > amount > =C2=A0 of packages that need it (e.g. for tests) that I'm not aware of. asturm asked me to reply here if I think the changes are in the spirit of xdg.eclass, so.. I'm not sure about the spirit, but I personally am fine with the changes, after the technical nitpicks are figured out in the thread here. I do not like at all that we'll need to remember about calling xdg_environment_reset sometimes, but the status quo of clashing with other eclasses src_prepare export is probably worse. And you needing this reset call or not is not at all immediately obvious - it causing trouble may only happen during test suite run, for example, when XDG_RUNTIME_DIR is written to, or something else ends up causing writes to it. Basically ENV_UNSET was a great start, but does not completely address our XDG env reset needs and it'd be great if someone championed a full solution for EAPI-9 or something. I'm starting to think the easiest is to just make the xdg_environment_reset call unconditionally in meson.eclass src_configure like cmake.eclass does, and forget all about this for almost all possible cases. That rant aside, I'm happy in spirit with the changes as proposed here. Mart --=-xHvN7ALxA+pLw/Av6R5n Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAABCgB9FiEEUdZn9pOq0mlNjRvdEKbJ+k9JlgYFAmEJKyBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDUx RDY2N0Y2OTNBQUQyNjk0RDhEMUJERDEwQTZDOUZBNEY0OTk2MDYACgkQEKbJ+k9J lgbvPg//YsMLMtCGEVYHjZbAUMcS4JM1/njf5lIGOpqilxoTcXzjZAtbf23FAGMA 7DzTTDQbIYVzmOpDguQPdZUj4urkcFize2tvm1c8i1TORFH1R4u4y9J1wUUmt/UB HdjJgfrtqtJEWyeBH1UmEy++kQb28umDNSBlayYp5Ry0+9AppGLhtixJ8knhwvz3 Fwzk17wQbVphdYBWvuStk5A5/ErNg1tRM1BhvGzsZuVt+m6w6l7xQQHp9dVdRXU3 toLkP7SNX1Xw9+mXnqFuRV1a/hEDx4tDufrR9bYVQwh69UpFH0JWxqj3fW1Qw8Wl jUIPNBrgMmrFF2S/rqJYUAtrpJ5BWdhg6omOu4z/QmDldH4xVOkfHhJ/CJdiSy1e BJw0bjWt9r0/GApipF41cAjfMUBHU5w84SSQO1FV/c1AouS6iTmjrQhFsx01qAqb CryJZ0lma2ZH42u3+PIlDmZDi7HTcFS62oJjxYuW7Q4YHPotLekIGw3ro7YLYbFs 0Kgwqe/KkodpCVd4u9z00oL+hKsttk+kbCogoQgTE9t/Pn9sIHHtFfYYo75ZsKS8 0W/ZRm9ALz7P+iSMyjjcUUAyTzXNAyFrMIPqtBZv1qxuBZ22JzsH08opbLUfp6Sg NrVtuAlbgVfqNWtKgwURUuX3PjQrmlBgLBh4SIl6vT2NKBeD/3k= =yqCR -----END PGP SIGNATURE----- --=-xHvN7ALxA+pLw/Av6R5n--