From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 60918158020 for ; Tue, 29 Nov 2022 22:15:11 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 0DC5DE08F3; Tue, 29 Nov 2022 22:15:06 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 9C7EAE08CD for ; Tue, 29 Nov 2022 22:15:05 +0000 (UTC) Message-ID: <9d77f3c0be43dc38a30c1c8024db9c784529547d.camel@gentoo.org> Subject: Re: [gentoo-dev] [PATCH] linux-info.eclass: getfilevar: pass 'need-compiler=' to make From: James Le Cuirot To: gentoo-dev@lists.gentoo.org Date: Tue, 29 Nov 2022 22:14:44 +0000 In-Reply-To: <20221129185544.1957747-1-floppym@gentoo.org> References: <20221129185544.1957747-1-floppym@gentoo.org> Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-ASeTz/r0NoW8QKoichDX" User-Agent: Evolution 3.44.4 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 X-Archives-Salt: 7292cbec-403e-49b5-abd7-37bcb565317b X-Archives-Hash: 5a5ff6a4d667aff0e8a95a381ac8c2ed --=-ASeTz/r0NoW8QKoichDX Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, 2022-11-29 at 13:55 -0500, Mike Gilbert wrote: > This avoids some unnecessary Makefile logic and gives a nice speed up. >=20 > Before the change, linux-info_pkg_setup takes 11 to 15 seconds on my > AMD Phenom II. After, it takes 3 to 4 seconds. >=20 > Signed-off-by: Mike Gilbert > --- > eclass/linux-info.eclass | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass > index fc125b0d751..3e64cb9457a 100644 > --- a/eclass/linux-info.eclass > +++ b/eclass/linux-info.eclass > @@ -238,7 +238,9 @@ getfilevar() { > # Pass dot-config=3D0 to avoid the config check in kernels prior to 5.= 4. > [[ ${EAPI:-0} =3D=3D [0123] ]] && nonfatal() { "$@"; } > echo -e "e:\\n\\t@echo \$(${1})\\ninclude ${basefname}" | \ > - nonfatal emake -C "${basedname}" --no-print-directory M=3D"${T}" dot-= config=3D0 need-config=3D ${BUILD_FIXES} -s -f - 2>/dev/null > + nonfatal emake -C "${basedname}" --no-print-directory M=3D"${T}" \ > + dot-config=3D0 need-config=3D need-compiler=3D \ > + ${BUILD_FIXES} -s -f - 2>/dev/null > =20 > ARCH=3D${myARCH} > fi I'm confused. Breaking up the line makes it faster? --=-ASeTz/r0NoW8QKoichDX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQJFBAABCAAvFiEEPxcZ3tkwcedKm2a8EiZBXQDdMTcFAmOGhFQRHGNoZXdpQGdl bnRvby5vcmcACgkQEiZBXQDdMTeQIg//S4lJKc3f6/30oowbis2Cu3yUf9uWQNnA cSEqHZQv8RHqkjAB2zRpAe4VghcdI/J+gO3OloUtXLglgGIATPQs4FQ7zeGlpzdV TX/vDmHAnm5GtnQ+1IJ1Xz3CspM48neQsP9vutLwHxP/MnG25Nf15kA7Nd7uy7cF j8MlZO71PJzroZ/tA8NPSn9V/BHRmOZDbXl+2AnkH5gNnkg+Z8sxJkYimrmqs4tk rxMqI7MsCn8ysx/h15st3Ud1yQxdMF0nra4XoE/yf8bk5ZstMpaL7rJ4L/g/ixv8 KBvlx54WG5T75JEjsRfR5cD7Q6YpvZs2jn/kRnaOyPu7fdzd+JEIo3OU0A1qh24O OetJq6M37UkcVGOLvC3rgdq9Od3rrFg2gLOThmRH0lRbRUZpZIVQo3BwTT7UZIKw ke0/SIeAh299SuelUIx79ZM2tgF3I+ww/4wPUDi/eyjpsL/OibVGdXbfSCahHx94 gP5Goy2es6iY+ZbCxDd/YA2Th/o3tVC85xXz/wnU0RJwzQiQywIo7RWrNSP0TvE6 K4pk9Fe0Mb3TBoJekp6XmlT7kcyPD/YfT2GG1fndmO++LRvCUu7BEam07fvPA6+8 yINkejHUWCGYvzrCDYHgAZbi8mtd/fCVFeMbFJBT7oHvVnOSfhZpbybeHR5Jft3H az2DWGLikRA= =zkT7 -----END PGP SIGNATURE----- --=-ASeTz/r0NoW8QKoichDX--