[gentoo-dev] [PATCH] profiles: update package.mask's header for GLEP 84

[gentoo-dev] [PATCH] profiles: update package.mask's header for GLEP 84

[alexey+gentoo]

From: Alexey Sokolov <alexey+gentoo@asokolov.org>

Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
---
 profiles/package.mask | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/profiles/package.mask b/profiles/package.mask
index b8bdd285f85d..fccb152787c9 100644
--- a/profiles/package.mask
+++ b/profiles/package.mask
@@ -1,6 +1,8 @@
 # Copyright 1999-2025 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
+# Uses GLEP 84 format
+
 ####################################################################
 #
 # When you add an entry to the top of this file, add your name, the date
@@ -20,15 +22,17 @@
 # - Best last rites (removal) practices -
 # Include the following info:
 # a) reason for masking
-# b) bug # for the removal (and yes you should have one)
-# c) date of removal (either the date or "in x days")
+# b) date of removal
+# c) bug # for the removal (and yes you should have one)
+#
+# See GLEP 84 for the full description of the format.
 #
 ## Example:
 ##
 ## # Dev E. Loper <developer@gentoo.org> (2019-07-01)
-## # Masked for removal in 30 days.  Doesn't work
-## # with new libfoo. Upstream dead, gtk-1, smells
-## # funny. (bug #987654)
+## # Doesn't work with new libfoo. Upstream dead, gtk-1, smells
+## # funny.
+## # Removal on 2019-08-01. Bug #987654.
 ## app-misc/some-package
 
 #--- END OF EXAMPLES ---
-- 
2.49.0

[gentoo-dev] Re: [PATCH] profiles: update package.mask's header for GLEP 84

[Duncan]

alexey+gentoo posted on Sat, 12 Apr 2025 20:20:38 +0000 as excerpted:

>  ## Example:
>  ##
>  ## # Dev E. Loper <developer@gentoo.org> (2019-07-01)
> -## # Masked for removal in 30 days.  Doesn't work
> -## # with new libfoo. Upstream dead, gtk-1, smells
> -## # funny. (bug #987654)
> +## # Doesn't work with new libfoo. Upstream dead, gtk-1, smells
> +## # funny.
> +## # Removal on 2019-08-01. Bug #987654.
>  ## app-misc/some-package

OCD triggered:

Two very optional (it's an example after all) suggestions given you're 
already changing it:

1) Example-timeliness niggle: s/gtk-1/qt5/ (or pick other appropriate...)

qt5 isn't out-of-tree yet but the effort is toward that /eventually/,
so it's a far more current example than gtk-1. (/How/ long has that been 
out-of-tree?)

2) Style niggle:  Wrapping a two-word phrase to put just one on a line by 
itself... [grumble, grumble].  Sentence line-breaks are even better
so maybe (example in-point, "maybe:" wrapped to its own line...):

> +## # Doesn't work with new libfoo.
> +## # Upstream dead, qt5, smells funny.

(Or maybe with the shorter qt5 it'll all fit on one line?)

Again, both entirely optional, but that /would/ satisfy my OCD. YMMV.

-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman

Re: [gentoo-dev] Re: [PATCH] profiles: update package.mask's header for GLEP 84

[Alexey Sokolov]

13.04.2025 14:36, Duncan пишет:
> alexey+gentoo posted on Sat, 12 Apr 2025 20:20:38 +0000 as excerpted:
>
>> ## Example:
>> ##
>> ## # Dev E. Loper <developer@gentoo.org> (2019-07-01)
>> -## # Masked for removal in 30 days. Doesn't work
>> -## # with new libfoo. Upstream dead, gtk-1, smells
>> -## # funny. (bug #987654)
>> +## # Doesn't work with new libfoo. Upstream dead, gtk-1, smells
>> +## # funny.
>> +## # Removal on 2019-08-01. Bug #987654.
>> ## app-misc/some-package
> OCD triggered:
>
> Two very optional (it's an example after all) suggestions given you're
> already changing it:
>
> 1) Example-timeliness niggle: s/gtk-1/qt5/ (or pick other appropriate...)
>
> qt5 isn't out-of-tree yet but the effort is toward that /eventually/,
> so it's a far more current example than gtk-1. (/How/ long has that been
> out-of-tree?)
>
> 2) Style niggle: Wrapping a two-word phrase to put just one on a line by
> itself... [grumble, grumble]. Sentence line-breaks are even better
> so maybe (example in-point, "maybe:" wrapped to its own line...):
>
>> +## # Doesn't work with new libfoo.
>> +## # Upstream dead, qt5, smells funny.
> (Or maybe with the shorter qt5 it'll all fit on one line?)
>
> Again, both entirely optional, but that /would/ satisfy my OCD. YMMV.
>
>

As this message isn't supposed to be used as is, but only as an example, 
gtk-1 is not bad as the example. But fine, made it gtk-2 instead.

Updated at https://github.com/gentoo/gentoo/pull/41563

Re: [gentoo-dev] Re: [PATCH] profiles: update package.mask's header for GLEP 84

[Sam James]

Duncan <1i5t5.duncan@cox.net> writes:

> alexey+gentoo posted on Sat, 12 Apr 2025 20:20:38 +0000 as excerpted:
>
>>  ## Example:
>>  ##
>>  ## # Dev E. Loper <developer@gentoo.org> (2019-07-01)
>> -## # Masked for removal in 30 days.  Doesn't work
>> -## # with new libfoo. Upstream dead, gtk-1, smells
>> -## # funny. (bug #987654)
>> +## # Doesn't work with new libfoo. Upstream dead, gtk-1, smells
>> +## # funny.
>> +## # Removal on 2019-08-01. Bug #987654.
>>  ## app-misc/some-package
>
> OCD triggered:
>
> Two very optional (it's an example after all) suggestions given you're 
> already changing it:
>
> 1) Example-timeliness niggle: s/gtk-1/qt5/ (or pick other appropriate...)
>
> qt5 isn't out-of-tree yet but the effort is toward that /eventually/,
> so it's a far more current example than gtk-1. (/How/ long has that been 
> out-of-tree?)

I think it's funnier if it's ancient.

Re: [gentoo-dev] Re: [PATCH] profiles: update package.mask's header for GLEP 84

[Alexey Sokolov]

15.04.2025 20:54, Sam James пишет:
> Duncan <1i5t5.duncan@cox.net> writes:
>
>> alexey+gentoo posted on Sat, 12 Apr 2025 20:20:38 +0000 as excerpted:
>>
>>>   ## Example:
>>>   ##
>>>   ## # Dev E. Loper <developer@gentoo.org> (2019-07-01)
>>> -## # Masked for removal in 30 days.  Doesn't work
>>> -## # with new libfoo. Upstream dead, gtk-1, smells
>>> -## # funny. (bug #987654)
>>> +## # Doesn't work with new libfoo. Upstream dead, gtk-1, smells
>>> +## # funny.
>>> +## # Removal on 2019-08-01. Bug #987654.
>>>   ## app-misc/some-package
>> OCD triggered:
>>
>> Two very optional (it's an example after all) suggestions given you're
>> already changing it:
>>
>> 1) Example-timeliness niggle: s/gtk-1/qt5/ (or pick other appropriate...)
>>
>> qt5 isn't out-of-tree yet but the effort is toward that /eventually/,
>> so it's a far more current example than gtk-1. (/How/ long has that been
>> out-of-tree?)
> I think it's funnier if it's ancient.
>
Okay, switched it back to gtk-1 in the PR, while preserving the whole 
sentence on one line