From: Michael Orlitzky <mjo@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] xorg-3.eclass: Copy from xorg-2.eclass and add EAPI 7 support
Date: Thu, 21 Feb 2019 07:50:10 -0500 [thread overview]
Message-ID: <9bfaa289-250b-9701-77e4-a187500d03c2@gentoo.org> (raw)
In-Reply-To: <20190221060957.775-1-mattst88@gentoo.org>
On 2/21/19 1:09 AM, Matt Turner wrote:
>
> 2) Suggestions welcome for solving https://bugs.gentoo.org/637898
> I have no ideas...
>
The eclass documentation script wants a fixed default value for
variables that are optional.
For XORG_MODULE, instead of a case statement,
if [[ -z ${XORG_MODULE} ]]; then
case ${CATEGORY} in
app-doc) XORG_MODULE=doc/ ;;
media-fonts) XORG_MODULE=font/ ;;
...
you could make the default value "auto" (or some other magic value), and
then document that "auto" will guess based on the package's category.
The same thing should work for XORG_MODULE_REBUILD. First, I would
ensure that DRIVER is set to either "yes" or "no" (right now it can be
empty, I think). Then make the default value for XORG_MODULE_REBUILD
something like "auto", and do
if [[ "${XORG_MODULE_REBUILD}" == auto ]]; then
XORG_MODULE_REBUILD="${DRIVER}"
fi
prev parent reply other threads:[~2019-02-21 12:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 6:09 [gentoo-dev] [PATCH] xorg-3.eclass: Copy from xorg-2.eclass and add EAPI 7 support Matt Turner
2019-02-21 12:50 ` Michael Orlitzky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bfaa289-250b-9701-77e4-a187500d03c2@gentoo.org \
--to=mjo@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox