From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Re: [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set
Date: Thu, 29 Feb 2024 15:37:14 +0100 [thread overview]
Message-ID: <980d8db20e0a28535929ef75f3a5d6683cf331c8.camel@gentoo.org> (raw)
In-Reply-To: <5a0b89a4-a742-4ce3-88ad-63f5b98e346e@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
On Thu, 2024-02-29 at 15:21 +0100, Florian Schmaus wrote:
> On 29/02/2024 15.08, Michael Orlitzky wrote:
> > On Thu, 2024-02-29 at 14:47 +0100, Florian Schmaus wrote:
> > > >
> > > > +if [[ -z ${TL_PV} ]] \
> > > > + && [[ ${EAPI} -ge 8 ]] \
> > >
> > > I am skeptical of this construct, as in the past we had non-numeric
> > > EAPIs. So I may have to go with EAPI == 8 for now. Input appreciated.
> > >
> >
> >
> > The eclass only supports EAPIs {7,8,...} so it should suffice to
> > blacklist EAPI=7.
>
> Fair point, but that would mean to remember to adjust this line once the
> eclass gets support for EAPI 9.
>
> It appears that bash does the right thing:
>
> $ if [[ "eapi-future" -gt 8 ]]; then echo "is greater than 8"; else echo
> "is NOT greater than 8"; fi
> is NOT greater than 8
>
> even considering
>
> $ if [[ "9-eapi-future" -gt 8 ]]; then echo "is greater than 8"; else
> echo "is NOT greater than 8"; fi
> is greater than 8
>
> which would be fine.
>
> Although I prefer the current approach, it is not a hill to die on for me.
>
It is invalid to treat EAPI as an integer.
The standard practice is to explicitly list old EAPIs, so that no
changes need to preserve the new behavior for new EAPIs.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2024-02-29 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 13:38 [gentoo-dev] [PATCH 0/3] *** Three minor changes to texlive-(common|mmodule).elcass *** Florian Schmaus
2024-02-29 13:38 ` [gentoo-dev] [PATCH 1/3] texlive-module.eclass: implicitly set TL_PV if not explicitly set Florian Schmaus
2024-02-29 13:47 ` [gentoo-dev] " Florian Schmaus
2024-02-29 14:08 ` Michael Orlitzky
2024-02-29 14:21 ` Florian Schmaus
2024-02-29 14:34 ` Michael Orlitzky
2024-02-29 14:36 ` Florian Schmaus
2024-02-29 14:37 ` Michał Górny [this message]
2024-02-29 13:38 ` [gentoo-dev] [PATCH 2/3] texlive-common.eclass: check exit status of texmf-update Florian Schmaus
2024-02-29 20:40 ` Ulrich Mueller
2024-03-01 8:47 ` Florian Schmaus
2024-03-01 9:00 ` Ulrich Mueller
2024-02-29 13:38 ` [gentoo-dev] [PATCH 3/3] texlive-common.eclass: Use nonfatal-respecting die for fmtutil-sys Florian Schmaus
2024-02-29 14:38 ` Michał Górny
2024-02-29 20:37 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=980d8db20e0a28535929ef75f3a5d6683cf331c8.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox