From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id DCAE0158091 for ; Mon, 13 Jun 2022 09:49:54 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 889F9E0896; Mon, 13 Jun 2022 09:49:51 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0E3DBE0877 for ; Mon, 13 Jun 2022 09:49:51 +0000 (UTC) Message-ID: <946afe9b-1eb8-b791-b151-66b7a34ec92b@gentoo.org> Date: Mon, 13 Jun 2022 11:49:46 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [gentoo-dev] [PATCH] go-module.eclass: undeprecate EGO_SUM Content-Language: en-US To: gentoo-dev@lists.gentoo.org References: <20220613074411.341909-1-flow@gentoo.org> <20220613074411.341909-2-flow@gentoo.org> From: Andrew Ammerlaan Organization: Gentoo Linux In-Reply-To: <20220613074411.341909-2-flow@gentoo.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Archives-Salt: 25a359e0-53ba-459c-bc53-72527327acdd X-Archives-Hash: 04f640dde444b9058e0d934dffa0ae18 On 13/06/2022 09:44, Florian Schmaus wrote: > Following the gentoo-dev@ mailing list discussion [1], this > un-deprecates EGO_SUM. > > 1: https://archives.gentoo.org/gentoo-dev/message/1a64a8e7694c3ee11cd48a58a95f2faa > > Signed-off-by: Florian Schmaus > --- > eclass/go-module.eclass | 30 +++++++++++------------------- > 1 file changed, 11 insertions(+), 19 deletions(-) > > diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass > index a5dafb45cab8..2e0b7dc1726d 100644 > --- a/eclass/go-module.eclass > +++ b/eclass/go-module.eclass > @@ -25,7 +25,9 @@ > # > # If the software has a directory named vendor in its > # top level directory, the only thing you need to do is inherit the > -# eclass. If it doesn't, you need to also create a dependency tarball and > +# eclass. If it doesn't, then you either 1) populate EGO_SUM in the ebuild and > +# call go-module_set_globals as discussed below or 2) you need to create a > +# dependency tarball and > # host it somewhere, for example in your dev space. > # > # Here is an example of how to create a dependency tarball. I agree that EGO_SUM shouldn't have been completely deprecated following the previous discussion. It is not always possible or practical to host a dependency tarball, especially for people who aren't Gentoo developers. However, from what I remember from the previous discussion there actually were some good arguments against using EGO_SUM, mainly relating to the size of the ebuilds and manifests. So perhaps we can find some middle ground here and keep EGO_SUM for e.g. third-party repositories, while recommending dependency tarballs for use in ::gentoo. Could we add something among those lines to the text here? Best regards, Andrew