From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id C37FB158009 for ; Wed, 21 Jun 2023 13:58:35 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F3EAFE08C8; Wed, 21 Jun 2023 13:58:31 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id ACE77E089F for ; Wed, 21 Jun 2023 13:58:31 +0000 (UTC) Message-ID: <92ac9bbb-7c82-115d-fd70-298ef39ef5a7@gentoo.org> Date: Wed, 21 Jun 2023 15:58:27 +0200 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US, nl-NL To: gentoo-dev@lists.gentoo.org References: <30d4b57b-734f-bd42-4427-15389256e80f@gentoo.org> <703cdee8-b322-6c49-be13-efd10426ea6b@gentoo.org> <06d53584-9c50-b819-cac5-abc17249c515@gentoo.org> <0b36b5e7-bb3f-2166-bb16-2fef8f35fde6@gentoo.org> From: Andrew Ammerlaan Organization: Gentoo Linux Subject: Re: [gentoo-dev] Eselect repository feature request In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Archives-Salt: c844ffb2-9302-47b7-be74-48e7316110e6 X-Archives-Hash: 3d1ee64893e4c61f4939efc433ff923a On 21/06/2023 15:40, TOMAS FABRIZIO ORSI wrote: > What I meant is that emerge --sync/eix --sync does this check > instead of > eselect repository. To me this makes sense since we can only do this > check *after* syncing. > > That is a great point; I had not considered it. > So, you are saying to have emerge --sync/eix --sync check the masters > key and then warn the user of not synced up overlays, correct? Yes > This however would require > that profiles/repo_name is always equal to the name entry in > repositories.xml, I'm not sure if this is currently always the case. > > I had not considered this possibility either. > If that's the case, then I believe there are to possible behaviors: > If the names do match, then emerge --sync/eix --sync could both: >      1. issue a warning of the missing overlay dependency >      2. run the command to add said overlay (with confirmation). > On the other hand, if the names do not match, a missing dependency warning > could be issued, skipping the second step. > This sounds to me to be fairly reasonable behaviour. > > In the cases where the names do not match; what could be the best > solution to "fix" this? Change repositories.xml on a case by case basis? > Ask overlay owners to change their profiles/repo_name and > profiles/masters key? Neither? I just checked the internal overlays team guide[1] and it does explicitly say that repo_name should match the repositories.xml . So probably there is no problem. That being said it is possible for the owner to change repo_name and (accidentally) not update repositories.xml. These cases should be fixed but exactly how would have to be determined on a case by case basis. In any case, this is just something to keep in mind when writing this check. It is not fully guaranteed that eselect repository can find the repository that is requested in some master= entry. Best regards, Andrew [1] https://wiki.gentoo.org/wiki/Project:Overlays/Internal_Overlays_team_guide