Re: [gentoo-dev] [PATCH v3 0/1] greadme.eclass: new eclass

[Florian Schmaus <flow@gentoo.org>]

On 13/06/2024 13.59, Ionen Wolkens wrote:
> On Thu, Jun 13, 2024 at 10:39:24AM +0200, Florian Schmaus wrote:
>> Following up on the discussion of the last patchset, this
>> - moves the functionally into a new eclass, as adjusting the existing
>>    eclass to export new phase functions is not viable.
>> - excludes the README.gentoo from decompression, as all other
>>    presented approaches add complexity and cause additional disk space
>>    consumption. While on the other hand, README.gentoo files are
>>    typically very small because they should be suitable as pkg_postinst
>>    output, so ther is often not much gained by compressing them.
>> - adds a GREADME_SHOW show option, to manually override the behavior
>>    (as requested by ionen).
> 
> I don't recall requesting anything, or was it something i said on
> IRC that I forgot about?

No, that seems to be a misunderstanding then. You wrote about the 
maintainer being able to choose when the readme is worth showing again 
and that a comparison would also "display it for minor style or typo
fixes.".

I thought that this was asking for a manual override. I am sorry, seems 
that I got that wrong.


> Also I assume GREADME_SHOW is actually GREADME_FORCE?

It's actually the other way around. Latest HEAD of greadme.eclass has

# @ECLASS_VARIABLE: GREADME_SHOW
# @DEFAULT_UNSET
# @DESCRIPTION:
# If set to "yes" then unconditionally show the contents of the readme
# file in pkg_postinst via elog. If set to "no", then do not show the
# contents of the readme file, even if they have changed.

- Flow