* [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
@ 2019-12-11 14:58 Michał Górny
2019-12-11 16:04 ` Aaron Bauman
2019-12-12 17:02 ` NP-Hardass
0 siblings, 2 replies; 6+ messages in thread
From: Michał Górny @ 2019-12-11 14:58 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
Append RESTRICT="!test? ( test )" in the default case when virtualx
is conditional to USE=test. This fixes 440 MissingTestRestrict
warnings.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
---
eclass/virtualx.eclass | 2 ++
1 file changed, 2 insertions(+)
diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
index 40eeea5463bc..6aba6bf488dd 100644
--- a/eclass/virtualx.eclass
+++ b/eclass/virtualx.eclass
@@ -89,6 +89,8 @@ case ${VIRTUALX_REQUIRED} in
fi
RDEPEND=""
IUSE="${VIRTUALX_REQUIRED}"
+ [[ ${VIRTUALX_REQUIRED} == test ]] &&
+ RESTRICT+=" !test? ( test )"
;;
esac
--
2.24.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
2019-12-11 14:58 [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default Michał Górny
@ 2019-12-11 16:04 ` Aaron Bauman
2019-12-12 17:02 ` NP-Hardass
1 sibling, 0 replies; 6+ messages in thread
From: Aaron Bauman @ 2019-12-11 16:04 UTC (permalink / raw
To: gentoo-dev; +Cc: Michał Górny
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Wed, Dec 11, 2019 at 03:58:33PM +0100, Michał Górny wrote:
> Append RESTRICT="!test? ( test )" in the default case when virtualx
> is conditional to USE=test. This fixes 440 MissingTestRestrict
> warnings.
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> eclass/virtualx.eclass | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> index 40eeea5463bc..6aba6bf488dd 100644
> --- a/eclass/virtualx.eclass
> +++ b/eclass/virtualx.eclass
> @@ -89,6 +89,8 @@ case ${VIRTUALX_REQUIRED} in
> fi
> RDEPEND=""
> IUSE="${VIRTUALX_REQUIRED}"
> + [[ ${VIRTUALX_REQUIRED} == test ]] &&
> + RESTRICT+=" !test? ( test )"
> ;;
> esac
>
> --
> 2.24.1
>
>
Acked-by: Aaron Bauman <bman@gentoo.org>
--
Cheers,
Aaron
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
2019-12-11 14:58 [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default Michał Górny
2019-12-11 16:04 ` Aaron Bauman
@ 2019-12-12 17:02 ` NP-Hardass
2019-12-12 17:14 ` Mike Gilbert
1 sibling, 1 reply; 6+ messages in thread
From: NP-Hardass @ 2019-12-12 17:02 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1.1: Type: text/plain, Size: 830 bytes --]
On 12/11/19 9:58 AM, Michał Górny wrote:
> Append RESTRICT="!test? ( test )" in the default case when virtualx
> is conditional to USE=test. This fixes 440 MissingTestRestrict
> warnings.
>
> Signed-off-by: Michał Górny <mgorny@gentoo.org>
> ---
> eclass/virtualx.eclass | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> index 40eeea5463bc..6aba6bf488dd 100644
> --- a/eclass/virtualx.eclass
> +++ b/eclass/virtualx.eclass
> @@ -89,6 +89,8 @@ case ${VIRTUALX_REQUIRED} in
> fi
> RDEPEND=""
> IUSE="${VIRTUALX_REQUIRED}"
> + [[ ${VIRTUALX_REQUIRED} == test ]] &&
> + RESTRICT+=" !test? ( test )"
> ;;
> esac
>
>
Is there a better way to address this than editing a ton of eclasses
independently?
--
NP-Hardass
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
2019-12-12 17:02 ` NP-Hardass
@ 2019-12-12 17:14 ` Mike Gilbert
2019-12-13 11:50 ` Alexis Ballier
0 siblings, 1 reply; 6+ messages in thread
From: Mike Gilbert @ 2019-12-12 17:14 UTC (permalink / raw
To: Gentoo Dev
On Thu, Dec 12, 2019 at 12:02 PM NP-Hardass <NP-Hardass@gentoo.org> wrote:
>
> On 12/11/19 9:58 AM, Michał Górny wrote:
> > Append RESTRICT="!test? ( test )" in the default case when virtualx
> > is conditional to USE=test. This fixes 440 MissingTestRestrict
> > warnings.
> >
> > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > ---
> > eclass/virtualx.eclass | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> > index 40eeea5463bc..6aba6bf488dd 100644
> > --- a/eclass/virtualx.eclass
> > +++ b/eclass/virtualx.eclass
> > @@ -89,6 +89,8 @@ case ${VIRTUALX_REQUIRED} in
> > fi
> > RDEPEND=""
> > IUSE="${VIRTUALX_REQUIRED}"
> > + [[ ${VIRTUALX_REQUIRED} == test ]] &&
> > + RESTRICT+=" !test? ( test )"
> > ;;
> > esac
> >
> >
>
> Is there a better way to address this than editing a ton of eclasses
> independently?
Not really.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
2019-12-12 17:14 ` Mike Gilbert
@ 2019-12-13 11:50 ` Alexis Ballier
2019-12-20 18:45 ` Kent Fredric
0 siblings, 1 reply; 6+ messages in thread
From: Alexis Ballier @ 2019-12-13 11:50 UTC (permalink / raw
To: gentoo-dev
On Thu, 2019-12-12 at 12:14 -0500, Mike Gilbert wrote:
> On Thu, Dec 12, 2019 at 12:02 PM NP-Hardass <NP-Hardass@gentoo.org>
> wrote:
> > On 12/11/19 9:58 AM, Michał Górny wrote:
> > > Append RESTRICT="!test? ( test )" in the default case when
> > > virtualx
> > > is conditional to USE=test. This fixes 440 MissingTestRestrict
> > > warnings.
> > >
> > > Signed-off-by: Michał Górny <mgorny@gentoo.org>
> > > ---
> > > eclass/virtualx.eclass | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
> > > index 40eeea5463bc..6aba6bf488dd 100644
> > > --- a/eclass/virtualx.eclass
> > > +++ b/eclass/virtualx.eclass
> > > @@ -89,6 +89,8 @@ case ${VIRTUALX_REQUIRED} in
> > > fi
> > > RDEPEND=""
> > > IUSE="${VIRTUALX_REQUIRED}"
> > > + [[ ${VIRTUALX_REQUIRED} == test ]] &&
> > > + RESTRICT+=" !test? ( test )"
> > > ;;
> > > esac
> > >
> > >
> >
> > Is there a better way to address this than editing a ton of
> > eclasses
> > independently?
>
> Not really.
>
Seems a good candidate for a future EAPI
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default
2019-12-13 11:50 ` Alexis Ballier
@ 2019-12-20 18:45 ` Kent Fredric
0 siblings, 0 replies; 6+ messages in thread
From: Kent Fredric @ 2019-12-20 18:45 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
On Fri, 13 Dec 2019 12:50:00 +0100
Alexis Ballier <aballier@gentoo.org> wrote:
> Seems a good candidate for a future EAPI
In theory, there are packages that can execute src_test when USE="test"
is not satisfied.
Just I don't tend to see this in practice.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-20 18:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-11 14:58 [gentoo-dev] [PATCH] virtualx.eclass: Append RESTRICT="!test? ( test )" by default Michał Górny
2019-12-11 16:04 ` Aaron Bauman
2019-12-12 17:02 ` NP-Hardass
2019-12-12 17:14 ` Mike Gilbert
2019-12-13 11:50 ` Alexis Ballier
2019-12-20 18:45 ` Kent Fredric
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox