public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Joerg Bornkessel <hd_brummy@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] vdr-plugin-2.eclass QA fix, please review, bug 778815
Date: Fri, 9 Apr 2021 23:10:44 +0200	[thread overview]
Message-ID: <8fa9f5b7-ae99-5cd0-6706-9c79c602efa8@gentoo.org> (raw)


[-- Attachment #1.1: Type: text/plain, Size: 837 bytes --]

https://bugs.gentoo.org/show_bug.cgi?id=778815

pkgcheck, gives an error like this
VariableScope: vdr-plugin-2: variable 'WORKDIR' used in 
'vdr-plugin-2_pkg_setup', line 371

inserted patch will fix this issues

<snip>
--- vdr-plugin-2.eclass 2020-02-23 17:39:40.000000000 +0100
+++ vdr-plugin-2_QA-fixed.eclass    2021-04-06 23:27:37.358477036 +0200
@@ -368,7 +368,7 @@
     VDR_INCLUDE_DIR="/usr/include/vdr"
     DVB_INCLUDE_DIR="/usr/include"

-   TMP_LOCALE_DIR="${WORKDIR}/tmp-locale"
+   TMP_LOCALE_DIR="${T}/tmp-locale"

     LOCDIR=$(pkg-config --variable=locdir vdr)
</snap>

i did several tests on my setup, it works like expected.
please review, thanks...

-- 
Joerg Bornkessel <hd_brummy@gentoo.org>
GnuPG Key: 0x93EB5F4DAA5832A1
Fingerprint: 0E0A A1EE 1DF4 41D7 A3F5 21C2 93EB 5F4D AA58 32A1


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]

             reply	other threads:[~2021-04-09 21:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 21:10 Joerg Bornkessel [this message]
2021-04-09 21:37 ` [gentoo-dev] vdr-plugin-2.eclass QA fix, please review, bug 778815 Sam James
2021-06-27 15:50   ` [gentoo-dev] [PATCH] vdr-plugin-2.eclass: add EAPI8 support, EAPI7+ fixes Martin Dummer
2021-06-27 18:57     ` Ulrich Mueller
2021-06-27 22:15       ` Martin Dummer
2021-06-28  6:18         ` Ulrich Mueller
2021-07-19  6:11           ` Martin Dummer
2021-07-19  7:02             ` Martin Dummer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8fa9f5b7-ae99-5cd0-6706-9c79c602efa8@gentoo.org \
    --to=hd_brummy@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox