From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 4A6AA1382C5 for ; Fri, 2 Mar 2018 08:53:27 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 93563E09DE; Fri, 2 Mar 2018 08:53:22 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 44355E0961 for ; Fri, 2 Mar 2018 08:53:22 +0000 (UTC) Received: from [IPv6:2001:44b8:4197:2800:a37a:5ec1:db17:1e49] (2001-44b8-4197-2800-a37a-5ec1-db17-1e49.static.ipv6.internode.on.net [IPv6:2001:44b8:4197:2800:a37a:5ec1:db17:1e49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kensington) by smtp.gentoo.org (Postfix) with ESMTPSA id 30F63335C36; Fri, 2 Mar 2018 08:53:18 +0000 (UTC) Subject: [gentoo-dev] Re: [PATCH] cmake-utils.eclass: Override CMAKE_INSTALL_{INFO,MAN}DIR To: gentoo-dev@lists.gentoo.org, =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= Cc: kde@gentoo.org, soap@gentoo.org References: <20180301154026.22031-1-mgorny@gentoo.org> From: Michael Palimaka Message-ID: <8eabcd0c-9601-b03a-f93c-7a16e60d2ee3@gentoo.org> Date: Fri, 2 Mar 2018 19:53:14 +1100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 In-Reply-To: <20180301154026.22031-1-mgorny@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Archives-Salt: 3b5ca335-b266-4dd2-9b0c-51300f951792 X-Archives-Hash: 2d5e867a365e2006411a1bf7a6830495 On 03/02/2018 02:40 AM, Michał Górny wrote: > Provide an explicit override for CMAKE_INSTALL_INFODIR > and CMAKE_INSTALL_MANDIR to force Gentoo standards for those locations. > This is needed for Gentoo/FreeBSD where CMake defaults to /usr/info > and /usr/man; while PMS specifies /usr/share/info and /usr/share/man > via econf & do* helpers. > --- > eclass/cmake-utils.eclass | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass > index b9f69a824b14..636927d66491 100644 > --- a/eclass/cmake-utils.eclass > +++ b/eclass/cmake-utils.eclass > @@ -602,6 +602,8 @@ cmake-utils_src_configure() { > SET (CMAKE_GENTOO_BUILD ON CACHE BOOL "Indicate Gentoo package build") > SET (LIB_SUFFIX ${libdir/lib} CACHE STRING "library path suffix" FORCE) > SET (CMAKE_INSTALL_LIBDIR ${libdir} CACHE PATH "Output directory for libraries") > + set (CMAKE_INSTALL_INFODIR "${EPREFIX}/usr/share/info" CACHE PATH "") > + set (CMAKE_INSTALL_MANDIR "${EPREFIX}/usr/share/man" CACHE PATH "") > _EOF_ > [[ "${NOCOLOR}" = true || "${NOCOLOR}" = yes ]] && echo 'SET (CMAKE_COLOR_MAKEFILE OFF CACHE BOOL "pretty colors during make" FORCE)' >> "${common_config}" > > There was some discussion in the past about adding these (and some others), but at that time it was postponed until EAPI 7 due to concerns about breaking existing packages. What do you think about the risk?