From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-98473-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 7DD6C158020
	for <garchives@archives.gentoo.org>; Thu, 10 Nov 2022 13:16:40 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 56D17E09E3;
	Thu, 10 Nov 2022 13:16:36 +0000 (UTC)
Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id 053A8E09D9
	for <gentoo-dev@lists.gentoo.org>; Thu, 10 Nov 2022 13:16:35 +0000 (UTC)
Message-ID: <8bfad42b-080d-72f8-7fd9-0e6a0f56d56d@gentoo.org>
Date: Thu, 10 Nov 2022 14:16:32 +0100
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [gentoo-dev] [PATCH 1/2] docs.eclass: allow multiple
 documentation builders
Content-Language: en-US, nl-NL
To: gentoo-dev@lists.gentoo.org
References: <32ed3f0d-e18d-ce92-9dc4-5e03a0ad07e4@gentoo.org>
 <Y2zir/kLWMYT3gcU@sysrq.in>
From: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Organization: Gentoo Linux
In-Reply-To: <Y2zir/kLWMYT3gcU@sysrq.in>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Archives-Salt: 231df4de-76cb-46fb-ae22-442fff6666ed
X-Archives-Hash: 0d5ba27d5d94b7dd10a39b966c3eba52

On 10/11/2022 12:38, Anna wrote:
> On 2022-11-10 12:29, Andrew Ammerlaan wrote:
>> diff --git a/eclass/docs.eclass b/eclass/docs.eclass
>> index 611485c227f..f7a82939a53 100644
>> --- a/eclass/docs.eclass
>> +++ b/eclass/docs.eclass
>> @@ -207,16 +207,15 @@ sphinx_deps() {
>>    }
>>
>>    # @FUNCTION: sphinx_compile
>> -# @INTERNAL
>>    # @DESCRIPTION:
>>    # Calls sphinx to build docs.
>> -#
>> -# If you overwrite python_compile_all do not call
>> -# this function, call docs_compile instead
>>    sphinx_compile() {
>>    	debug-print-function ${FUNCNAME}
>>    	use doc || return
>>
>> +	: ${DOCS_DIR:="${S}"}
>> +	: ${DOCS_OUTDIR:="${S}/_build/html/sphinx"}
>> +
> 
> Could it be local?

I guess, but to me that feels a bit weird and confusing because this 
variable can also be set globally in the ebuild.