From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
	by finch.gentoo.org with esmtp (Exim 4.60)
	(envelope-from <gentoo-dev+bounces-34383-garchives=archives.gentoo.org@lists.gentoo.org>)
	id 1La5QE-0006Rj-ET
	for garchives@archives.gentoo.org; Thu, 19 Feb 2009 09:42:22 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 7A782E02AB;
	Thu, 19 Feb 2009 09:42:21 +0000 (UTC)
Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.188])
	by pigeon.gentoo.org (Postfix) with ESMTP id 176E0E02AB
	for <gentoo-dev@lists.gentoo.org>; Thu, 19 Feb 2009 09:42:20 +0000 (UTC)
Received: by ti-out-0910.google.com with SMTP id j3so186937tid.10
        for <gentoo-dev@lists.gentoo.org>; Thu, 19 Feb 2009 01:42:20 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:received:in-reply-to:references
         :date:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        bh=2A6nChgZUaSZC4vfLtwh1SCYQemG4Li79OfdFuxT1iw=;
        b=VXFusIjeLldVjfB37kr+gpOmXNMbmVZCgaW8mTalC32iz7J2oiZQQlYVM6Z+/hm/50
         8jjSYmJDAsPSBYBkQ509lAG8ZSZqxM5AXv8NOz22RFuYJoySZ1n81Amo8SdI1OJdmK88
         j84CtMNXFnqngZLozA0X9eqZae2nRJUHT7Lu4=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=fSdcPKflOfu+73CN8D/IRiRXoKlsWcLY9ni1Iq/StJpvs8VkisyLDdtjxA8aFIAWdF
         nnKLmXVSfo3GUEglGymwYg4jW16gAmtRoU1UhfqsGtLWXq2fKAgV4OgYqn238qqqnx/e
         +cGQVqDeefKf+4wkLqbM33yOC1MA/UPgqYdzU=
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Received: by 10.110.62.4 with SMTP id k4mr1034687tia.52.1235036539167; Thu, 19 
	Feb 2009 01:42:19 -0800 (PST)
In-Reply-To: <18845.9642.146547.895690@a1ihome1.kph.uni-mainz.de>
References: <20090214132152.2aff08a0@terra.solaris> <49970B3F.40809@gentoo.org>
	 <20090215064941.GC13006@comet> <20090219095927.65e82e61@terra.solaris>
	 <18845.9642.146547.895690@a1ihome1.kph.uni-mainz.de>
Date: Thu, 19 Feb 2009 15:12:19 +0530
Message-ID: <8b4c83ad0902190142t5fe724ib8dfb494767f39ec@mail.gmail.com>
Subject: Re: [gentoo-dev] Re: bzr.eclass
From: Nirbheek Chauhan <nirbheek.chauhan@gmail.com>
To: gentoo-dev@lists.gentoo.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Archives-Salt: f8ba6a53-6942-458b-b742-67c877cdc891
X-Archives-Hash: b480499090b708b6c9c8ac5042cd1901

On Thu, Feb 19, 2009 at 2:56 PM, Ulrich Mueller <ulm@gentoo.org> wrote:
> -DEPEND=">=dev-util/bzr-1.5
> -    dev-util/diffstat"
> +DEPEND=">=dev-util/bzr-1.5"
>
> -        ${EBZR_DIFF_CMD} | diffstat
> +        [ -x /usr/bin/diffstat ] && ${EBZR_DIFF_CMD} | /usr/bin/diffstat
>

Isn't this better?

type diffstat &>/dev/null && {EBZR_DIFF_CMD} | diffstat

It's independent of where diffstat is (in PATH or otherwise)

-- 
~Nirbheek Chauhan