From mboxrd@z Thu Jan 1 00:00:00 1970
Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org)
by finch.gentoo.org with esmtp (Exim 4.60)
(envelope-from <gentoo-dev+bounces-33937-garchives=archives.gentoo.org@lists.gentoo.org>)
id 1LJklz-0000PL-Lr
for garchives@archives.gentoo.org; Mon, 05 Jan 2009 08:25:20 +0000
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
by pigeon.gentoo.org (Postfix) with SMTP id B95E0E0471;
Mon, 5 Jan 2009 08:25:16 +0000 (UTC)
Received: from ti-out-0910.google.com (ti-out-0910.google.com [209.85.142.191])
by pigeon.gentoo.org (Postfix) with ESMTP id 5826BE0471
for <gentoo-dev@lists.gentoo.org>; Mon, 5 Jan 2009 08:25:16 +0000 (UTC)
Received: by ti-out-0910.google.com with SMTP id u5so5694661tia.10
for <gentoo-dev@lists.gentoo.org>; Mon, 05 Jan 2009 00:25:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=gamma;
h=domainkey-signature:received:received:message-id:date:from:to
:subject:in-reply-to:mime-version:content-type
:content-transfer-encoding:content-disposition:references;
bh=t0ZVVHkvTf/35QiiFwtvlNJf3TSYajtV0d18PAqPf5c=;
b=wAQDt6RFFql1H2eQuSa4A9okUC5yM9F70MCV90+YxFj60F2b8v4vbHbVRj5r/XcnFD
PrZZNR+KAfebd7ozmaI/P7s2jADiO268uox5I9QBJrehXroPAuuhcpVCnImSzJzj9CzD
5o6ZclD39SanGtr5tEOQs5ZAIZXqNLU6SXbF0=
DomainKey-Signature: a=rsa-sha1; c=nofws;
d=gmail.com; s=gamma;
h=message-id:date:from:to:subject:in-reply-to:mime-version
:content-type:content-transfer-encoding:content-disposition
:references;
b=dgm9GoheAxZvoO6fIGecHjubYEGXXxjzhtIWEIp0tkzfKxXdftkp4geVutruVTI7r/
LJEON2JkOvxIboIsVAEooGuj9dQ/fncOwmgifHaFDUlGZdyiEFRzY6QJihq7JlW7TBpc
5iDy0XIAb9/wy7m/wHZ8oSs2PXFjRis9+ovks=
Received: by 10.110.50.19 with SMTP id x19mr5060945tix.57.1231143915361;
Mon, 05 Jan 2009 00:25:15 -0800 (PST)
Received: by 10.110.47.7 with HTTP; Mon, 5 Jan 2009 00:25:15 -0800 (PST)
Message-ID: <8b4c83ad0901050025k2356e1e4nbf40ea3fe86b7a57@mail.gmail.com>
Date: Mon, 5 Jan 2009 13:55:15 +0530
From: "Nirbheek Chauhan" <nirbheek.chauhan@gmail.com>
To: gentoo-dev@lists.gentoo.org, patrick@gentoo.org
Subject: Re: [gentoo-dev] Re: gentoo-x86 commit in app-forensics/memdump: memdump-1.0.1.ebuild ChangeLog
In-Reply-To: <20090105010331.TA8dca0.tv@veller.net>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <E1LJcf9-00025P-UZ@stork.gentoo.org>
<20090105010331.TA8dca0.tv@veller.net>
X-Archives-Salt: 9bf2c393-e2f9-4151-bb48-cfcd8a68e936
X-Archives-Hash: 7a8e276642a049500ddfa81a54beee81
On Mon, Jan 5, 2009 at 5:37 AM, Torsten Veller <ml-en@veller.net> wrote:
> * "Patrick Lauer (patrick)" <patrick@gentoo.org>:
>> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-forensics/memdump/memdump-1.0.1.ebuild?rev=1.1&view=markup
>> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-forensics/memdump/memdump-1.0.1.ebuild?rev=1.1&content-type=text/plain
>>
>> Index: memdump-1.0.1.ebuild
>> ===================================================================
>> # Copyright 1999-2009 Gentoo Foundation
>> # Distributed under the terms of the GNU General Public License v2
>> # $Header: /var/cvsroot/gentoo-x86/app-forensics/memdump/memdump-1.0.1.ebuild,v 1.1 2009/01/04 23:45:43 patrick Exp $
>>
>> DESCRIPTION="Simple memory dumper for UNIX-Like systems"
>> HOMEPAGE="http://www.porcupine.org/forensics"
>> SRC_URI="http://www.porcupine.org/forensics/${PN}-1.01.tar.gz"
> ~~~~
Missing MY_PV I presume?
>> LICENSE="IBM"
>> SLOT="0"
>> KEYWORDS="~amd64 ~ppc ~x86"
>> DEPEND="sys-apps/sed
>> sys-apps/grep"
>> RDEPEND="virtual/libc"
> ^^^^^^^^^^^^^^^^^^^^^^
Useless deps which are already in @system?
>
>> IUSE=""
>>
>>
>> S=${WORKDIR}/${PN}-1.01
> ~~~~
Quotes and ${MY_PV} missing?
>> src_compile() {
>> cd ${S}/memdump-1.01
> " " ~~~~
Quotes, and ${PN}-${MY_PV} ?
Although, should this even be required since ${S} is already set correctly?
Does the tarball have a folder inside a folder?
>> einfo "testing"
>> if [ "`./memdump -s 344 | wc -c`" = "344" ];
>> then
>> einfo "passed test"
>> else
>> die "failed test"
>> fi
Here, why not use
einfo "testing"
[ "`./memdump -s 344 | wc -c`" = "344" ] || die "failed test"
einfo "passed test"
--
~Nirbheek Chauhan