From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id BC7BD1382C5 for ; Fri, 26 Jun 2020 17:41:23 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 21F6EE09CD; Fri, 26 Jun 2020 17:41:19 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id C67FCE0969 for ; Fri, 26 Jun 2020 17:41:18 +0000 (UTC) Date: Fri, 26 Jun 2020 13:41:13 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <20200626174724.614c9b15@sf> References: <20200620135742.2603768-1-slyfox@gentoo.org> <20200620162953.010f09a0@sf> <20200626074257.4bb72e3c@sf> <63A7D0EB-038E-4CD9-B6CF-B45D6A573938@gentoo.org> <20200626095158.19489282@sf> <233ada786a31958a050fe21cdbd89792f6ad7a4c.camel@gentoo.org> <20200626174724.614c9b15@sf> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [gentoo-dev] [PATCH] profiles/package.deprecated: deprecate python:2.7 To: gentoo-dev@lists.gentoo.org From: Aaron Bauman Message-ID: <8CCC5CD0-9A2B-42AC-9169-7DA9C60CE40E@gentoo.org> X-Archives-Salt: 33fef266-3886-41e7-8193-0e7712306e67 X-Archives-Hash: cc8a2fcc2b54a3d91dee9bf466b40c27 On June 26, 2020 12:47:24 PM EDT, Sergei Trofimovich = wrote: >On Fri, 26 Jun 2020 11:38:58 +0200 >Micha=C5=82 G=C3=B3rny wrote: > >> On Fri, 2020-06-26 at 09:51 +0100, Sergei Trofimovich wrote: >> > On Fri, 26 Jun 2020 07:29:45 +0000 >> > Micha=C5=82 G=C3=B3rny wrote: >> > =20 >> > > Dnia June 26, 2020 6:42:57 AM UTC, Sergei Trofimovich > napisa=C5=82(a): =20 >> > > > On Sat, 20 Jun 2020 16:29:53 +0100 >> > > > Sergei Trofimovich wrote: >> > > > =20 >> > > > > On Sat, 20 Jun 2020 16:05:38 +0200 >> > > > > Micha=C5=82 G=C3=B3rny wrote: >> > > > > =20 >> > > > > > On Sat, 2020-06-20 at 14:57 +0100, Sergei Trofimovich >wrote: =20 >> > > > > > > Give maintainers the chance to act and flag packages that >pull in =20 >> > > > python:2=2E7=2E =20 >> > > > > > > Signed-off-by: Sergei Trofimovich >> > > > > > > --- >> > > > > > > profiles/package=2Edeprecated | 4 ++++ >> > > > > > > 1 file changed, 4 insertions(+) >> > > > > > >=20 >> > > > > > > diff --git a/profiles/package=2Edeprecated =20 >> > > > b/profiles/package=2Edeprecated =20 >> > > > > > > index a756e845f47=2E=2Ebb661571962 100644 >> > > > > > > --- a/profiles/package=2Edeprecated >> > > > > > > +++ b/profiles/package=2Edeprecated >> > > > > > > @@ -17,6 +17,10 @@ >> > > > > > > =20 >> > > > > > > #--- END OF EXAMPLES --- >> > > > > > > =20 >> > > > > > > +# Sergei Trofimovich (2020-06-20) >> > > > > > > +# Deprecated=2E Consider poring to python 3 and drop >support for =20 >> > > > python2=2E =20 >> > > > > > > +dev-lang/python:2=2E7 >> > > > > > > + >> > > > > > > # Sergei Trofimovich (2020-02-22) >> > > > > > > # virtual/libstdc++ has only one sys-libs/libstdc++-v3 >provider=2E >> > > > > > > # Use that instead=2E Or even better use none of them=2E >It's a =20 >> > > > > > =20 >> > > > > =20 >> > > > > > It will trigger the same for packages that support *only* >> > > > > > Python 2=2E7, as well as these that support 2=2E7 in addition >to 3 =20 >> > > > because =20 >> > > > > > they have 2=2E7 deps=2E =20 >> > > > >=20 >> > > > > If we expect actions by developers on both cases I don't see >a =20 >> > > > problem with that=2E >> > > >=20 >> > > > Pushed as: >> > > > >https://gitweb=2Egentoo=2Eorg/repo/gentoo=2Egit/commit/?id=3D79d65d6641cf= c0ef7b44df491c390e8c880e3049 >> > > > with full text being: >> > > >=20 >> > > > +# Sergei Trofimovich (2020-06-26) >> > > > +# Deprecated=2E >> > > > +# - optional python:2=2E7 dependency should be dropped if no >reverse >> > > > +# dependencies are using it=2E >> > > > +# - mandatory python:2=2E7 depepndency will require package >porting >> > > > +# or package removal if no reverse dependencies are using >it=2E >> > > > +dev-lang/python:2=2E7 =20 >> > >=20 >> > > You've just introduced 829 CI warnings =20 >> >=20 >> > That's the intention=2E >> > =20 >> > > effectively disabling the ability to distinguish *new* problems >in these packages=2E =20 >> >=20 >> > Correct=2E Citing above: >> >=20 >> > "If we expect actions by developers on both cases I don't see a=20 >problem with that=2E" >> >=20 >> > I assume we still do=2E =20 >>=20 >> Not exactly=2E You've pinpointed the wrong target=2E >>=20 >> First of all, we want people to support Python 3=2E Removing support >for >> Python 2 is a secondary goal=2E > >What is the desired end state here? All packages that depend on >python should support python3? > >> Flagging packages that support Python 2 in addition to Python 3 >> and cause no trouble in py2 cleanup is doubtful=2E > >What is "py2 cleanup"? I still struggle to understand what packages >require change and which do not=2E Is there one pager doc that explains >a few things for me: >- How packages are picked for masking? Maybe we can deprecate them >instead? Or we (I) can write a bit of code that flags packages >requiring > maintainers' attention=2E >- What is the expected end state for the "py2 cleanup"?=20 > >The doc would also be a good link to add to recently added "# Py2 only" >masks as well=2E > >> Flagging packages that support 2+3 because of their revdeps is not >> helpful at all=2E It's just noise to the maintainer who can't remove >py2 >> because of revdeps=2E > >I agree it can be spammy if we expect to have many packages with >python2 support for an extended period of time (3+ months)=2E If it's >seen by others as too noisy I can revert the commit now=2E > >> Flagging dev-python/pypy* which needs py2 but is entirely outside >> the eclass system is not helpful at all=2E > >To pick a concrete example: from what I read above I don't see why >app-misc/golly was masked for removal=2E It was masked because it only supports Py2=2E The maintainer (you) decided= to drop Python script support=2E Problem solved=2E Easy day=2E All done=2E= =20 As discussed elsewhere, there are tools to show which packages only suppor= t Py2 etc=2E=20 There is no discrimination of which packages get masked and when=2E Additi= onally, masking seems to drive the attention vice all the other discussions= , bugs, etc=2E=20 As we can see, folks will complain no matter what method is used=2E I coul= d spend my days opening bugs and hoping for a response, yelling loudly on t= he ML for others to "pitch in" etc=2E In the end, the mask seems to work quickest when only a couple of people c= an sift through the packages in the tree=2E We have a deadline=2E=2E=2E Look at the list of packages masked for removal and how many get "saved=2E= " I think it is fairly clear how effective it is=2E=2E=2E Without wasting t= ime opening bugs, begging on the ML for support, explaining that there are = tools to help devs see these things etc=2E=20 --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E