From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: Mike Gilbert <floppym@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH 2/2] sys-apps/systemd-utils: add workaround for no-multilib
Date: Tue, 26 Mar 2024 17:51:42 +0100 [thread overview]
Message-ID: <8800cc9d191aebeb15604c42087cd5cf9dcad819.camel@gentoo.org> (raw)
In-Reply-To: <20240326150152.1932785-2-floppym@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
On Tue, 2024-03-26 at 11:01 -0400, Mike Gilbert wrote:
> meson.build has some logic to build ia32 EFI binaries on x86_64 if the
> toolchain is compatible. Rather than trying to reproduce this logic in
> the ebuild, just try to build it and ignore any failures.
>
> If meson.build actually defines the targets but we have some other
> compile error, this will move the failure to the install phase instead.
>
That's not a correct use of nonfatal. It is supposed to be used to
provide customized error handling (e.g. cleanup step before dying), not
a cheap way to ignore errors.
--
Best regards,
Michał Górny
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 512 bytes --]
next prev parent reply other threads:[~2024-03-26 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 15:01 [gentoo-dev] [PATCH 1/2] meson.eclass: call die -n in phase helpers Mike Gilbert
2024-03-26 15:01 ` [gentoo-dev] [PATCH 2/2] sys-apps/systemd-utils: add workaround for no-multilib Mike Gilbert
2024-03-26 16:51 ` Michał Górny [this message]
2024-03-26 16:57 ` Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8800cc9d191aebeb15604c42087cd5cf9dcad819.camel@gentoo.org \
--to=mgorny@gentoo.org \
--cc=floppym@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox