From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-101016-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 40806158451
	for <garchives@archives.gentoo.org>; Wed, 10 Jan 2024 11:03:40 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 2160FE2A2C;
	Wed, 10 Jan 2024 11:03:37 +0000 (UTC)
Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id BBE42E29DC
	for <gentoo-dev@lists.gentoo.org>; Wed, 10 Jan 2024 11:03:36 +0000 (UTC)
References: <2cbe001a5fbea17c3222ec09f4d6e2d6cfc7e36c.camel@gentoo.org>
 <4cf06ce7-545c-4d25-b179-ee0a33b11265@uls.co.za>
 <d5c193a578b39a4420475005b481b01d6e36226c.camel@gentoo.org>
 <0ca39f35-86a3-4777-bf20-d5d36cdf68c6@uls.co.za>
User-agent: mu4e 1.10.8; emacs 30.0.50
From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Last rites: app-admin/fluentd
Date: Wed, 10 Jan 2024 11:02:39 +0000
Organization: Gentoo
In-reply-to: <0ca39f35-86a3-4777-bf20-d5d36cdf68c6@uls.co.za>
Message-ID: <87y1cxmovv.fsf@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Archives-Salt: aa254f14-f3c6-4243-a195-b2fea816c75d
X-Archives-Hash: cf655c783ea1255b8aaba5eed1f66334


Jaco Kroon <jaco@uls.co.za> writes:

> Hi,
>
> On 2024/01/09 13:42, Micha=C5=82 G=C3=B3rny wrote:
>> On Tue, 2024-01-09 at 12:54 +0200, Jaco Kroon wrote:
>>> https://github.com/gentoo/gentoo/pull/34126 ??
>>>
>>> Perhaps I'm missing something if you say it's non-trivial but we're
>>> using that on 9 hosts currently.
>>>
>> Do tests pass for you?  https://bugs.gentoo.org/879181#c2 indicated that
>> they do not.
>
> How critical is it that they do?
>
> Even for the bump PR they do not, they fail with the below, and
> frankly my knowledge of ruby is outright scary.=C2=A0 The below to me
> indicates that the tests are designed specifically to run from a git
> checkout, there are two possible "fixes":
>
> 1.=C2=A0 patch the code to not require this.
> 2.=C2=A0 disable tests.
>
>>>> Test phase: app-admin/fluentd-1.16.3
> =C2=A0* Running test phase for ruby31
> [...]
> [...]
> <internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_requir=
e.rb>:85:in
> `require': cannot load such file -- rr (LoadError)

Try adding a test dep on dev-ruby/rr.

Anyway, if it works for you in production, and you're willing to
(reluctantly) adopt it, then we can work on the tests later.