public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Sam James <sam@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Last rites: app-admin/fluentd
Date: Wed, 10 Jan 2024 11:02:39 +0000	[thread overview]
Message-ID: <87y1cxmovv.fsf@gentoo.org> (raw)
In-Reply-To: <0ca39f35-86a3-4777-bf20-d5d36cdf68c6@uls.co.za>


Jaco Kroon <jaco@uls.co.za> writes:

> Hi,
>
> On 2024/01/09 13:42, Michał Górny wrote:
>> On Tue, 2024-01-09 at 12:54 +0200, Jaco Kroon wrote:
>>> https://github.com/gentoo/gentoo/pull/34126 ??
>>>
>>> Perhaps I'm missing something if you say it's non-trivial but we're
>>> using that on 9 hosts currently.
>>>
>> Do tests pass for you?  https://bugs.gentoo.org/879181#c2 indicated that
>> they do not.
>
> How critical is it that they do?
>
> Even for the bump PR they do not, they fail with the below, and
> frankly my knowledge of ruby is outright scary.  The below to me
> indicates that the tests are designed specifically to run from a git
> checkout, there are two possible "fixes":
>
> 1.  patch the code to not require this.
> 2.  disable tests.
>
>>>> Test phase: app-admin/fluentd-1.16.3
>  * Running test phase for ruby31
> [...]
> [...]
> <internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in
> `require': cannot load such file -- rr (LoadError)

Try adding a test dep on dev-ruby/rr.

Anyway, if it works for you in production, and you're willing to
(reluctantly) adopt it, then we can work on the tests later.


  reply	other threads:[~2024-01-10 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31 10:34 [gentoo-dev] Last rites: app-admin/fluentd Michał Górny
2024-01-09 10:54 ` Jaco Kroon
2024-01-09 11:42   ` Michał Górny
2024-01-09 16:19     ` Jaco Kroon
2024-01-10 11:02       ` Sam James [this message]
2024-01-10 14:20         ` Jaco Kroon
2024-01-13  9:38           ` Hans de Graaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1cxmovv.fsf@gentoo.org \
    --to=sam@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox