From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 3E7B7158451 for ; Wed, 10 Jan 2024 11:05:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 03DC7E2A3B; Wed, 10 Jan 2024 11:05:54 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 95B89E29E2 for ; Wed, 10 Jan 2024 11:05:53 +0000 (UTC) References: <20240106170153.1581902-1-flow@gentoo.org> User-agent: mu4e 1.10.8; emacs 30.0.50 From: Sam James To: gentoo-dev@lists.gentoo.org Cc: pacho@gentoo.org, Florian Schmaus Subject: Re: [gentoo-dev] [PATCH 0/1] [RFC] greadme.eclass Date: Wed, 10 Jan 2024 11:04:20 +0000 Organization: Gentoo In-reply-to: <20240106170153.1581902-1-flow@gentoo.org> Message-ID: <87r0ipmos3.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain X-Archives-Salt: 92ba3db9-d0a0-47a5-a427-fb2550564d7a X-Archives-Hash: 5525580d009653896cb04f117a815cff Florian Schmaus writes: > I really like the functionality of readme.gentoo-r1.eclass, as it > allows to communicate Gentoo-specific information about a package to > the user. Especially as it improves the signal-to-noise ratio of > messages arriving to our users. > > However, readme.gentoo-r1.eclass will only show this information on > new installs, but not if the information changed. This is a major > drawback. Furthermore, readme.gentoo-r1.eclass does not provide an API > to assemble the information via heredoc. > > The following patch includes a new eclass named "greadme", that > addresses those shortcomings of readme.gentoo-r1.eclass and hopefully > can be seen as a general overhaul. I have a few concerns at the moment, but of varying severity: 1) The name seems odd (why not readme.gentoo-r2)? 2) Why can't the existing eclass be improved? 3) Is the reason for 2) strong enough to introduce a new eclass? 4) The compression deal seems not worth bothering with. I don't really want to see a bifurcation in our README eclasses if we can help it. Porting to something new takes ages and it's a lot of churn.