From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 34897158064 for ; Mon, 13 May 2024 15:05:37 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 40873E2AB6; Mon, 13 May 2024 15:05:31 +0000 (UTC) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D1835E2AB0 for ; Mon, 13 May 2024 15:05:30 +0000 (UTC) From: Sam James To: Florian Schmaus Cc: gentoo-dev@lists.gentoo.org, qa@gentoo.org Subject: Re: [gentoo-dev] [PATCH 0/2] edo.eclass: enhace edob for usage with nosiy commands In-Reply-To: <20240508171505.48392-1-flow@gentoo.org> (Florian Schmaus's message of "Wed, 8 May 2024 19:15:03 +0200") Organization: Gentoo References: <20240508171505.48392-1-flow@gentoo.org> Date: Mon, 13 May 2024 16:05:26 +0100 Message-ID: <87pltphhvt.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain X-Archives-Salt: db1775a3-46de-435c-b4ac-0637c07650e3 X-Archives-Hash: 937510348139621cb1091b1cceb4497f Florian Schmaus writes: > The motivation for this change is to allow edob to be used with noisy > commands, i.e., commands that produce a lot of output, in cases where > the output is in general not of interest. However, if the command > fails, the output should be shown and appear in build.log. > > We do this by simply redirecting the output to a file in $T, and show > this file if the command returned a non-zero exit status. > > We already have a few cases in ::gentoo where such output is simply > redirected to /dev/null, hindering post-mortem analysis. Those could > be converted to edob with its new behavior. > > PR at https://github.com/gentoo/gentoo/pull/36117 > LGTM. I agree there's value in it. > Florian Schmaus (2): > edo.eclass: enhace edob for usage with nosiy commands s/nosiy/noisy/ > eftmutil-sys: use edob > > eclass/edo.eclass | 54 ++++++++++++++++++++++++++++++++---- > eclass/texlive-common.eclass | 8 ++++-- > 2 files changed, 53 insertions(+), 9 deletions(-)