From: Sam James <sam@gentoo.org>
To: Florian Schmaus <flow@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, qa@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 0/2] edo.eclass: enhace edob for usage with nosiy commands
Date: Mon, 13 May 2024 16:05:26 +0100 [thread overview]
Message-ID: <87pltphhvt.fsf@gentoo.org> (raw)
In-Reply-To: <20240508171505.48392-1-flow@gentoo.org> (Florian Schmaus's message of "Wed, 8 May 2024 19:15:03 +0200")
Florian Schmaus <flow@gentoo.org> writes:
> The motivation for this change is to allow edob to be used with noisy
> commands, i.e., commands that produce a lot of output, in cases where
> the output is in general not of interest. However, if the command
> fails, the output should be shown and appear in build.log.
>
> We do this by simply redirecting the output to a file in $T, and show
> this file if the command returned a non-zero exit status.
>
> We already have a few cases in ::gentoo where such output is simply
> redirected to /dev/null, hindering post-mortem analysis. Those could
> be converted to edob with its new behavior.
>
> PR at https://github.com/gentoo/gentoo/pull/36117
>
LGTM. I agree there's value in it.
> Florian Schmaus (2):
> edo.eclass: enhace edob for usage with nosiy commands
s/nosiy/noisy/
> eftmutil-sys: use edob
>
> eclass/edo.eclass | 54 ++++++++++++++++++++++++++++++++----
> eclass/texlive-common.eclass | 8 ++++--
> 2 files changed, 53 insertions(+), 9 deletions(-)
prev parent reply other threads:[~2024-05-13 15:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 17:15 [gentoo-dev] [PATCH 0/2] edo.eclass: enhace edob for usage with nosiy commands Florian Schmaus
2024-05-08 17:15 ` [gentoo-dev] [PATCH 1/2] " Florian Schmaus
2024-05-19 9:06 ` gentoo
2024-05-08 17:15 ` [gentoo-dev] [PATCH 2/2] eftmutil-sys: use edob Florian Schmaus
2024-05-13 15:05 ` Sam James [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pltphhvt.fsf@gentoo.org \
--to=sam@gentoo.org \
--cc=flow@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=qa@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox