From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D5E3615806E for ; Sun, 28 May 2023 13:37:58 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 783DAE0848; Sun, 28 May 2023 13:37:55 +0000 (UTC) Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 35493E0805 for ; Sun, 28 May 2023 13:37:55 +0000 (UTC) References: <20230528131641.13289-1-ulm@gentoo.org> User-agent: mu4e 1.10.3; emacs 29.0.91 From: Sam James To: gentoo-dev@lists.gentoo.org Cc: base-system@gentoo.org, Ulrich =?utf-8?Q?M=C3=BCller?= Subject: Re: [gentoo-dev] [PATCH 1/3] autotools.eclass: Downgrade eqawarn for renaming configure.in Date: Sun, 28 May 2023 14:36:58 +0100 In-reply-to: <20230528131641.13289-1-ulm@gentoo.org> Message-ID: <87mt1ozidt.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: e65833c0-39e1-40e5-8d0d-5d5292e5a3f3 X-Archives-Hash: 3da30ed2940d687cf76ac5de8a4ab227 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ulrich M=C3=BCller writes: > At this point, almost all upstreams will have switched to configure.ac. > Therefore, configure.in is most likely an indication of an inactive > upstream, and there is no useful way for the ebuild maintainer to > silence the warning (other than the ebuild renaming the file). Ionen's point was that such packages therefore regularly get updates so a QA warning when rarely revbumping it isn't necessarily a problem eithe= r. But I also don't think it's likely that upstream will ever actually enforce this, so OK. > > Keep the message as einfo, so there is still an indication that the file > was renamed. > > Bug: https://bugs.gentoo.org/426262 > Signed-off-by: Ulrich M=C3=BCller > --- > eclass/autotools.eclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass > index 91046b9f82f3..3a040b863eea 100644 > --- a/eclass/autotools.eclass > +++ b/eclass/autotools.eclass > @@ -400,7 +400,7 @@ eautoconf() { > *) > # Move configure file to the new location only on newer EAPIs to ens= ure > # checks are done rather than retroactively breaking ebuilds. > - eqawarn "Moving configure.in to configure.ac (bug #426262)" > + einfo "Moving configure.in to configure.ac (bug #426262)" > mv configure.{in,ac} || die > ;; > esac --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZHNZLl8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZDq2gEA8dTeUnTEl281waGV+pXD+DzCG1OTK0J/71wd 0C9+dMQBAL+8wczac5P278ZNV1eW99RAO+IbNUA7AUko+s4q4VEP =+sgZ -----END PGP SIGNATURE----- --=-=-=--