From: Benda Xu <heroxbd@gentoo.org>
To: Yiyang Wu <xgreenlandforwyy@gmail.com>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] rocm.eclass: Fix the xnack feature for gfx90a
Date: Mon, 27 Nov 2023 08:08:40 +0800 [thread overview]
Message-ID: <87msv06os7.fsf@aurora.g.airelinux.org> (raw)
In-Reply-To: <20231117032201.5213-1-xgreenlandforwyy@gmail.com> (Yiyang Wu's message of "Fri, 17 Nov 2023 11:21:17 +0800")
Hi Yiyang,
Yiyang Wu <xgreenlandforwyy@gmail.com> writes:
> Upstream usually ships 2 version: gfx90a:xnack-, gfx90a:xnack+. Although
> a single gfx90a should have maximum compatibility, According to [1,2],
> compile with xnack+/xnack- may have better performance on xnack
> enabled/disabled GPUs. Therefore we ship both the target, align with
> upstream. gfx900 is also appended with :xnack- to align with upstream
> default.
> [1] https://llvm.org/docs/AMDGPUUsage.html#target-features
> [2] https://docs.olcf.ornl.gov/systems/crusher_quick_start_guide.html#compiling-hip-kernels-for-specific-xnack-modes
So, you want to add a new ABI to gfx90a for experimental xnack feature.
I suggest make it gfx908a with gfx908a_xnack, instead of
"gfx908a_noxnack" for consistency the existing naming scheme.
With this minimal modification, the remaining cards such as gfx906 and
gfx908 that support xnack could be updated incrementally.
Benda
next prev parent reply other threads:[~2023-11-27 0:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 3:21 [gentoo-dev] [PATCH 1/2] rocm.eclass: Fix the xnack feature for gfx90a Yiyang Wu
2023-11-17 3:21 ` [gentoo-dev] [PATCH 2/2] profiles/desc/amdgpu_targets.desc: Fill in more GPU models Yiyang Wu
2023-11-27 0:08 ` Benda Xu [this message]
2023-12-06 7:44 ` [gentoo-dev] [PATCH 1/2] rocm.eclass: Fix the xnack feature for gfx90a WuYiyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87msv06os7.fsf@aurora.g.airelinux.org \
--to=heroxbd@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=xgreenlandforwyy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox