[gentoo-dev] [PATCH] toolchain.eclass: Remove kludge that blocks gcc-6+ on sys-libs/uclibc-ng systems

[gentoo-dev] [PATCH] toolchain.eclass: Remove kludge that blocks gcc-6+ on sys-libs/uclibc-ng systems

[Joshua Kinard]

The following kludge is present in toolchain.eclass, in 
toolchain_pkg_pretend():

	[[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
		die "Sorry, this version does not support uClibc"

The below patch removes this.  I've been running a gcc-6-built,
sys-libs/uclibc-ng in chroot for some time now, have completed several
catalyst runs, and am at the tail end of a fresh install of a
sys-libs/uclibc-ng userland on actual MIPS hardware.

Signed-off-by: Joshua Kinard <kumba@gentoo.org>
---
 eclass/toolchain.eclass |    3 ---
 1 file changed, 3 deletions(-)

--- a/eclass/toolchain.eclass.orig	2017-07-29 19:06:30.894211203 -0400
+++ b/eclass/toolchain.eclass	2017-07-29 19:06:40.514211133 -0400
@@ -375,9 +375,6 @@ toolchain_pkg_pretend() {
 			"in your make.conf if you want to use this version."
 	fi
 
-	[[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
-		die "Sorry, this version does not support uClibc"
-
 	if ! use_if_iuse cxx ; then
 		use_if_iuse go && ewarn 'Go requires a C++ compiler, disabled due to USE="-cxx"'
 		use_if_iuse objc++ && ewarn 'Obj-C++ requires a C++ compiler, disabled due to USE="-cxx"'

Re: [gentoo-dev] [PATCH] toolchain.eclass: Remove kludge that blocks gcc-6+ on sys-libs/uclibc-ng systems

[Sergei Trofimovich]

[-- Attachment #1: Type: text/plain, Size: 1385 bytes --]

On Sat, 29 Jul 2017 19:12:23 -0400
Joshua Kinard <kumba@gentoo.org> wrote:

> The following kludge is present in toolchain.eclass, in 
> toolchain_pkg_pretend():
> 
> 	[[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
> 		die "Sorry, this version does not support uClibc"
> 
> The below patch removes this.  I've been running a gcc-6-built,
> sys-libs/uclibc-ng in chroot for some time now, have completed several
> catalyst runs, and am at the tail end of a fresh install of a
> sys-libs/uclibc-ng userland on actual MIPS hardware.
> 
> Signed-off-by: Joshua Kinard <kumba@gentoo.org>
> ---
>  eclass/toolchain.eclass |    3 ---
>  1 file changed, 3 deletions(-)
> 
> --- a/eclass/toolchain.eclass.orig	2017-07-29 19:06:30.894211203 -0400
> +++ b/eclass/toolchain.eclass	2017-07-29 19:06:40.514211133 -0400
> @@ -375,9 +375,6 @@ toolchain_pkg_pretend() {
>  			"in your make.conf if you want to use this version."
>  	fi
>  
> -	[[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
> -		die "Sorry, this version does not support uClibc"
> -
>  	if ! use_if_iuse cxx ; then
>  		use_if_iuse go && ewarn 'Go requires a C++ compiler, disabled due to USE="-cxx"'
>  		use_if_iuse objc++ && ewarn 'Obj-C++ requires a C++ compiler, disabled due to USE="-cxx"'
> 
> 

[  CCed toolchain@ as maintainer ]

Looks good.

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

Re: [gentoo-dev] [PATCH] toolchain.eclass: Remove kludge that blocks gcc-6+ on sys-libs/uclibc-ng systems

[Matthias Maier]

++


On Sun, Jul 30, 2017, at 02:46 CDT, Sergei Trofimovich <slyfox@gentoo.org> wrote:

> On Sat, 29 Jul 2017 19:12:23 -0400
> Joshua Kinard <kumba@gentoo.org> wrote:
>
>> The following kludge is present in toolchain.eclass, in 
>> toolchain_pkg_pretend():
>> 
>> 	[[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
>> 		die "Sorry, this version does not support uClibc"
>> 
>> The below patch removes this.  I've been running a gcc-6-built,
>> sys-libs/uclibc-ng in chroot for some time now, have completed several
>> catalyst runs, and am at the tail end of a fresh install of a
>> sys-libs/uclibc-ng userland on actual MIPS hardware.
>> 
>> Signed-off-by: Joshua Kinard <kumba@gentoo.org>

Signed-off-by: Matthias Maier <tamiko@gentoo.org>

>> ---
>>  eclass/toolchain.eclass |    3 ---
>>  1 file changed, 3 deletions(-)
>> 
>> --- a/eclass/toolchain.eclass.orig	2017-07-29 19:06:30.894211203 -0400
>> +++ b/eclass/toolchain.eclass	2017-07-29 19:06:40.514211133 -0400
>> @@ -375,9 +375,6 @@ toolchain_pkg_pretend() {
>>  			"in your make.conf if you want to use this version."
>>  	fi
>>  
>> -	[[ -z ${UCLIBC_VER} ]] && [[ ${CTARGET} == *-uclibc* ]] && \
>> -		die "Sorry, this version does not support uClibc"
>> -
>>  	if ! use_if_iuse cxx ; then
>>  		use_if_iuse go && ewarn 'Go requires a C++ compiler, disabled due to USE="-cxx"'
>>  		use_if_iuse objc++ && ewarn 'Obj-C++ requires a C++ compiler, disabled due to USE="-cxx"'

Best,
Matthias