From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 69877158008 for ; Thu, 15 Jun 2023 21:13:13 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 69105E09AE; Thu, 15 Jun 2023 21:13:10 +0000 (UTC) Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 29C2EE099F for ; Thu, 15 Jun 2023 21:13:10 +0000 (UTC) References: <20230615155240.589982-1-sam@gentoo.org> <20230615155240.589982-10-sam@gentoo.org> <2023615162751-ZIs8B4QuEytBT1s_-arkamar@atlas.cz> User-agent: mu4e 1.10.3; emacs 29.0.91 From: Sam James To: Petr =?utf-8?Q?Van=C4=9Bk?= Cc: gentoo-dev@lists.gentoo.org, ruby@gentoo.org Subject: Re: [gentoo-dev] [PATCH 10/11] ruby-ng.eclass: use shopt directly, not via estack.eclass Date: Thu, 15 Jun 2023 22:12:50 +0100 In-reply-to: <2023615162751-ZIs8B4QuEytBT1s_-arkamar@atlas.cz> Message-ID: <87jzw4h1jy.fsf@gentoo.org> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Archives-Salt: b2632d43-4b33-457e-85fe-82376aaada2f X-Archives-Hash: 4037f5a5bedc46c44a9542e10421dc59 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Petr Van=C4=9Bk writes: > On Thu, Jun 15, 2023 at 04:52:37PM +0100, Sam James wrote: >> ulm points out that estack.eclass is particularly inefficient (although >> it'll get slightly better once https://github.com/gentoo/gentoo/pull/314= 37 >> is fixed). >>=20 >> Let's just manually roll it like llvm.eclass does. >>=20 >> Bug: https://bugs.gentoo.org/908465 >> Signed-off-by: Sam James >> --- >> eclass/ruby-ng.eclass | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >>=20 >> diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass >> index 14f4414337d6f..8fe26057e7ffe 100644 >> --- a/eclass/ruby-ng.eclass >> +++ b/eclass/ruby-ng.eclass >> @@ -163,7 +163,8 @@ _RUBY_ATOMS_SAMELIB_RESULT=3D"" >> _ruby_atoms_samelib() { >> _RUBY_ATOMS_SAMELIB_RESULT=3D"" >>=20=20 >> - eshopts_push -o noglob >> + local shopt_save=3D$(shopt -p -o noglob) > ^~~~~~~~ > Wrong indentation - expanded tab instead of tab >> + set -f Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZIt+4l8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZD0HgEAlB2khzTalJ/pFkMtuIikG4LQGHcP3XSqD293 cst3TREA/3MpR/ZjH5EFb33FAdKbNmN/hAsg7T8XhAGp72ttsH0K =DAdx -----END PGP SIGNATURE----- --=-=-=--